Re: [Xen-devel] [PATCH] x86/hvm: Corrections and improvements to unhandled vmexit logging

2017-04-21 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Wednesday, April 19, 2017 11:58 PM > > * Use gprintk rather than gdprintk. These logging messages shouldn't >disappear in release builds, as they usually happen immediately before a >domain crash. Raise them from WARNING

Re: [Xen-devel] [PATCH] x86/hvm: Corrections and improvements to unhandled vmexit logging

2017-04-20 Thread Julien Grall
Hi Andrew, On 19/04/17 16:58, Andrew Cooper wrote: * Use gprintk rather than gdprintk. These logging messages shouldn't disappear in release builds, as they usually happen immediately before a domain crash. Raise them from WARNING to ERR. * Format the vmexit reason in the same base as

Re: [Xen-devel] [PATCH] x86/hvm: Corrections and improvements to unhandled vmexit logging

2017-04-20 Thread Jan Beulich
>>> On 20.04.17 at 13:01, wrote: > On 20/04/17 11:52, Jan Beulich wrote: >> >>> On 19.04.17 at 17:58, wrote: >>> --- a/xen/arch/x86/hvm/svm/svm.c >>> +++ b/xen/arch/x86/hvm/svm/svm.c >>> @@ -2833,10 +2833,9 @@ void svm_vmexit_handler(struct

Re: [Xen-devel] [PATCH] x86/hvm: Corrections and improvements to unhandled vmexit logging

2017-04-20 Thread Andrew Cooper
On 20/04/17 11:52, Jan Beulich wrote: > >>> On 19.04.17 at 17:58, wrote: >> --- a/xen/arch/x86/hvm/svm/svm.c >> +++ b/xen/arch/x86/hvm/svm/svm.c >> @@ -2833,10 +2833,9 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) >> >> default: >>

Re: [Xen-devel] [PATCH] x86/hvm: Corrections and improvements to unhandled vmexit logging

2017-04-20 Thread Jan Beulich
>>> On 19.04.17 at 17:58, wrote: > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -2833,10 +2833,9 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) > > default: > unexpected_exit_type: > -gdprintk(XENLOG_ERR,

Re: [Xen-devel] [PATCH] x86/hvm: Corrections and improvements to unhandled vmexit logging

2017-04-19 Thread Boris Ostrovsky
On 04/19/2017 11:58 AM, Andrew Cooper wrote: > * Use gprintk rather than gdprintk. These logging messages shouldn't >disappear in release builds, as they usually happen immediately before a >domain crash. Raise them from WARNING to ERR. > * Format the vmexit reason in the same base as

[Xen-devel] [PATCH] x86/hvm: Corrections and improvements to unhandled vmexit logging

2017-04-19 Thread Andrew Cooper
* Use gprintk rather than gdprintk. These logging messages shouldn't disappear in release builds, as they usually happen immediately before a domain crash. Raise them from WARNING to ERR. * Format the vmexit reason in the same base as is used in the vendor manuals (decimal for Intel,