Re: [Xen-devel] [PATCH] x86/mm: Drop MEM_LOG() and correct some printed information

2017-03-29 Thread Andrew Cooper
On 29/03/17 15:01, Jan Beulich wrote: On 29.03.17 at 15:50, wrote: >> On 29/03/17 14:06, Jan Beulich wrote: >> On 29.03.17 at 14:29, wrote: @@ -1068,10 +1073,10 @@ get_page_from_l1e( return 0; could_not_pin: -MEM_LOG("Error getting mfn %lx (pfn %lx)

Re: [Xen-devel] [PATCH] x86/mm: Drop MEM_LOG() and correct some printed information

2017-03-29 Thread Jan Beulich
>>> On 29.03.17 at 15:50, wrote: > On 29/03/17 14:06, Jan Beulich wrote: > On 29.03.17 at 14:29, wrote: >>> @@ -1068,10 +1073,10 @@ get_page_from_l1e( >>> return 0; >>> >>> could_not_pin: >>> -MEM_LOG("Error getting mfn %lx (pfn %lx) from L1 entry %" PRIpte >>> -" for

Re: [Xen-devel] [PATCH] x86/mm: Drop MEM_LOG() and correct some printed information

2017-03-29 Thread Andrew Cooper
On 29/03/17 14:06, Jan Beulich wrote: On 29.03.17 at 14:29, wrote: >> * Use 0x prefix for otherwise unqualified hex numbers. > I'm glad this in fact refers to just a single place. > >> @@ -1057,10 +1062,10 @@ get_page_from_l1e( >> put_page_type(page); >> put_pag

Re: [Xen-devel] [PATCH] x86/mm: Drop MEM_LOG() and correct some printed information

2017-03-29 Thread Jan Beulich
>>> On 29.03.17 at 14:29, wrote: > * Use 0x prefix for otherwise unqualified hex numbers. I'm glad this in fact refers to just a single place. > @@ -1057,10 +1062,10 @@ get_page_from_l1e( > put_page_type(page); > put_page(page); > > -MEM_LOG("Error up

[Xen-devel] [PATCH] x86/mm: Drop MEM_LOG() and correct some printed information

2017-03-29 Thread Andrew Cooper
MEM_LOG() is just a thin wrapper around gdprintk(), obscuring some of the common information. Inline it, and take the opportunity to correct some of the printked information. Some corrections, each where appropriate: * Correction of pfn/mfn terms and consistent use of PRI_pfn/mfn. * s!I/O!MMIO!