Re: [Xen-devel] [PATCH] x86/mtrr: use stdbool instead of int + define

2017-01-05 Thread Andrew Cooper
On 05/01/17 17:17, Doug Goldstein wrote: > On 1/5/17 11:08 AM, Jan Beulich wrote: > On 05.01.17 at 17:26, wrote: >>> -static void set_fixed_range(int msr, int * changed, unsigned int * >>> msrwords) >>> +static void set_fixed_range(int msr, bool * changed, unsigned int * >>> msrwords) >> Wou

Re: [Xen-devel] [PATCH] x86/mtrr: use stdbool instead of int + define

2017-01-05 Thread Doug Goldstein
On 1/5/17 11:08 AM, Jan Beulich wrote: On 05.01.17 at 17:26, wrote: >> -static void set_fixed_range(int msr, int * changed, unsigned int * msrwords) >> +static void set_fixed_range(int msr, bool * changed, unsigned int * >> msrwords) > > Would have been nice to get the stray blanks here and

Re: [Xen-devel] [PATCH] x86/mtrr: use stdbool instead of int + define

2017-01-05 Thread Jan Beulich
>>> On 05.01.17 at 17:26, wrote: > -static void set_fixed_range(int msr, int * changed, unsigned int * msrwords) > +static void set_fixed_range(int msr, bool * changed, unsigned int * msrwords) Would have been nice to get the stray blanks here and elsewhere dropped, as the lines are being touched

Re: [Xen-devel] [PATCH] x86/mtrr: use stdbool instead of int + define

2017-01-05 Thread Andrew Cooper
On 05/01/17 16:26, Doug Goldstein wrote: > Instead of using an int and providing a define for TRUE and FALSE, > change the code to use stdbool that Xen provides. > > Signed-off-by: Doug Goldstein Reviewed-by: Andrew Cooper and queued ___ Xen-devel mai

[Xen-devel] [PATCH] x86/mtrr: use stdbool instead of int + define

2017-01-05 Thread Doug Goldstein
Instead of using an int and providing a define for TRUE and FALSE, change the code to use stdbool that Xen provides. Signed-off-by: Doug Goldstein --- xen/arch/x86/cpu/mtrr/generic.c | 21 +++-- xen/arch/x86/cpu/mtrr/mtrr.h| 5 - 2 files changed, 11 insertions(+), 15 del