Re: [Xen-devel] [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available"

2016-02-12 Thread Andrew Cooper
On 12/02/16 10:57, Jan Beulich wrote: On 12.02.16 at 11:50, wrote: >> On 12/02/16 10:12, Jan Beulich wrote: >> On 12.02.16 at 11:02, wrote: On 12/02/16 10:00, Jan Beulich wrote: On 12.02.16 at 10:51, wrote: >> On 12/02/16 08:23, Jan Beulich wrote: >> On 11.02.1

Re: [Xen-devel] [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available"

2016-02-12 Thread Jan Beulich
>>> On 12.02.16 at 11:50, wrote: > On 12/02/16 10:12, Jan Beulich wrote: > On 12.02.16 at 11:02, wrote: >>> On 12/02/16 10:00, Jan Beulich wrote: >>> On 12.02.16 at 10:51, wrote: > On 12/02/16 08:23, Jan Beulich wrote: > On 11.02.16 at 20:25, wrote: >>> CentOS 7 gets int

Re: [Xen-devel] [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available"

2016-02-12 Thread Andrew Cooper
On 12/02/16 10:12, Jan Beulich wrote: On 12.02.16 at 11:02, wrote: >> On 12/02/16 10:00, Jan Beulich wrote: >> On 12.02.16 at 10:51, wrote: On 12/02/16 08:23, Jan Beulich wrote: On 11.02.16 at 20:25, wrote: >> CentOS 7 gets into trouble when compiling Xen citing: >

Re: [Xen-devel] [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available"

2016-02-12 Thread Jan Beulich
>>> On 12.02.16 at 11:02, wrote: > On 12/02/16 10:00, Jan Beulich wrote: > On 12.02.16 at 10:51, wrote: >>> On 12/02/16 08:23, Jan Beulich wrote: >>> On 11.02.16 at 20:25, wrote: > CentOS 7 gets into trouble when compiling Xen citing: > > flushtlb.c: Assembler messages: >>>

Re: [Xen-devel] [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available"

2016-02-12 Thread Andrew Cooper
On 12/02/16 10:00, Jan Beulich wrote: On 12.02.16 at 10:51, wrote: >> On 12/02/16 08:23, Jan Beulich wrote: >> On 11.02.16 at 20:25, wrote: CentOS 7 gets into trouble when compiling Xen citing: flushtlb.c: Assembler messages: flushtlb.c:149: Error: value of 256 to

Re: [Xen-devel] [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available"

2016-02-12 Thread Jan Beulich
>>> On 12.02.16 at 10:51, wrote: > On 12/02/16 08:23, Jan Beulich wrote: > On 11.02.16 at 20:25, wrote: >>> CentOS 7 gets into trouble when compiling Xen citing: >>> >>> flushtlb.c: Assembler messages: >>> flushtlb.c:149: Error: value of 256 too large for field of 1 bytes at 1 >>> >>> The

Re: [Xen-devel] [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available"

2016-02-12 Thread Andrew Cooper
On 12/02/16 08:23, Jan Beulich wrote: On 11.02.16 at 20:25, wrote: >> CentOS 7 gets into trouble when compiling Xen citing: >> >> flushtlb.c: Assembler messages: >> flushtlb.c:149: Error: value of 256 too large for field of 1 bytes at 1 >> >> The line number is wrong, and the error messag

Re: [Xen-devel] [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available"

2016-02-12 Thread Andrew Cooper
On 12/02/16 08:13, Jan Beulich wrote: On 11.02.16 at 20:41, wrote: >> On 11/02/16 19:25, Andrew Cooper wrote: >>> --- a/xen/arch/x86/flushtlb.c >>> +++ b/xen/arch/x86/flushtlb.c >>> @@ -141,10 +141,10 @@ void flush_area_local(const void *va, unsigned int >>> flags) >>> { >>>

Re: [Xen-devel] [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available"

2016-02-12 Thread Jan Beulich
>>> On 11.02.16 at 20:25, wrote: > CentOS 7 gets into trouble when compiling Xen citing: > > flushtlb.c: Assembler messages: > flushtlb.c:149: Error: value of 256 too large for field of 1 bytes at 1 > > The line number is wrong, and the error message not helpful. It turns out > that the int

Re: [Xen-devel] [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available"

2016-02-12 Thread Jan Beulich
>>> On 11.02.16 at 20:41, wrote: > On 11/02/16 19:25, Andrew Cooper wrote: >> --- a/xen/arch/x86/flushtlb.c >> +++ b/xen/arch/x86/flushtlb.c >> @@ -141,10 +141,10 @@ void flush_area_local(const void *va, unsigned int >> flags) >> { >> alternative(ASM_NOP3, "sfence", X86_FEAT

Re: [Xen-devel] [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available"

2016-02-11 Thread Doug Goldstein
On 2/11/16 1:25 PM, Andrew Cooper wrote: > CentOS 7 gets into trouble when compiling Xen citing: > > flushtlb.c: Assembler messages: > flushtlb.c:149: Error: value of 256 too large for field of 1 bytes at 1 > > The line number is wrong, and the error message not helpful. It turns out > that

Re: [Xen-devel] [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available"

2016-02-11 Thread Andrew Cooper
On 11/02/16 19:25, Andrew Cooper wrote: > CentOS 7 gets into trouble when compiling Xen citing: > > flushtlb.c: Assembler messages: > flushtlb.c:149: Error: value of 256 too large for field of 1 bytes at 1 > > The line number is wrong, and the error message not helpful. It turns out > that the

[Xen-devel] [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available"

2016-02-11 Thread Andrew Cooper
CentOS 7 gets into trouble when compiling Xen citing: flushtlb.c: Assembler messages: flushtlb.c:149: Error: value of 256 too large for field of 1 bytes at 1 The line number is wrong, and the error message not helpful. It turns out that the intermediate generated assembly was # 139 "arch/