Re: [Xen-devel] [PATCH] x86: re-add stack alignment check

2016-11-15 Thread Jan Beulich
>>> On 15.11.16 at 11:26, wrote: > On 14/11/16 16:54, Jan Beulich wrote: > On 14.11.16 at 17:38, wrote: >>> On 14/11/16 15:02, Jan Beulich wrote: >>> On 14.11.16 at 15:38, wrote: > On 14/11/16 14:24,

Re: [Xen-devel] [PATCH] x86: re-add stack alignment check

2016-11-15 Thread Andrew Cooper
On 14/11/16 16:54, Jan Beulich wrote: On 14.11.16 at 17:38, wrote: >> On 14/11/16 15:02, Jan Beulich wrote: >> On 14.11.16 at 15:38, wrote: On 14/11/16 14:24, Jan Beulich wrote: On 14.11.16 at 14:45,

Re: [Xen-devel] [PATCH] x86: re-add stack alignment check

2016-11-14 Thread Jan Beulich
>>> On 14.11.16 at 17:38, wrote: > On 14/11/16 15:02, Jan Beulich wrote: > On 14.11.16 at 15:38, wrote: >>> On 14/11/16 14:24, Jan Beulich wrote: >>> On 14.11.16 at 14:45, wrote: > On 14/11/16 13:25,

Re: [Xen-devel] [PATCH] x86: re-add stack alignment check

2016-11-14 Thread Andrew Cooper
On 14/11/16 15:02, Jan Beulich wrote: On 14.11.16 at 15:38, wrote: >> On 14/11/16 14:24, Jan Beulich wrote: >> On 14.11.16 at 14:45, wrote: On 14/11/16 13:25, Jan Beulich wrote: > --- a/xen/arch/x86/cpu/common.c > +++

Re: [Xen-devel] [PATCH] x86: re-add stack alignment check

2016-11-14 Thread Jan Beulich
>>> On 14.11.16 at 15:38, wrote: > On 14/11/16 14:24, Jan Beulich wrote: > On 14.11.16 at 14:45, wrote: >>> On 14/11/16 13:25, Jan Beulich wrote: --- a/xen/arch/x86/cpu/common.c +++ b/xen/arch/x86/cpu/common.c @@ -643,6

Re: [Xen-devel] [PATCH] x86: re-add stack alignment check

2016-11-14 Thread Andrew Cooper
On 14/11/16 14:24, Jan Beulich wrote: On 14.11.16 at 14:45, wrote: >> On 14/11/16 13:25, Jan Beulich wrote: >>> --- a/xen/arch/x86/cpu/common.c >>> +++ b/xen/arch/x86/cpu/common.c >>> @@ -643,6 +643,11 @@ void load_system_tables(void) >>> .limit =

Re: [Xen-devel] [PATCH] x86: re-add stack alignment check

2016-11-14 Thread Jan Beulich
>>> On 14.11.16 at 15:24, wrote: On 14.11.16 at 14:45, wrote: >> The BUILD_BUG_ON() is useful to retain, but I would suggest making >> get_stack_bottom() a static inline and putting the BUILD_BUG_ON() there. > > I would agree if we were to not

Re: [Xen-devel] [PATCH] x86: re-add stack alignment check

2016-11-14 Thread Jan Beulich
>>> On 14.11.16 at 14:45, wrote: > On 14/11/16 13:25, Jan Beulich wrote: >> --- a/xen/arch/x86/cpu/common.c >> +++ b/xen/arch/x86/cpu/common.c >> @@ -643,6 +643,11 @@ void load_system_tables(void) >> .limit = (IDT_ENTRIES * sizeof(idt_entry_t)) - 1, >>

Re: [Xen-devel] [PATCH] x86: re-add stack alignment check

2016-11-14 Thread Andrew Cooper
On 14/11/16 13:25, Jan Beulich wrote: > Commit 279840d5ea ("x86/boot: install trap handlers much earlier on > boot"), perhaps not really intentionally, removed this check. Add it No - that was deliberate. The check isn't useful (see below). > back, > - preventing it to trigger before any output

[Xen-devel] [PATCH] x86: re-add stack alignment check

2016-11-14 Thread Jan Beulich
Commit 279840d5ea ("x86/boot: install trap handlers much earlier on boot"), perhaps not really intentionally, removed this check. Add it back, - preventing it to trigger before any output is set up, - accompanying it with a (weaker, due to its open coding of what get_stack_bottom() does) build