Re: [Xen-devel] [PATCH] xen/arm: gic-v3: Implement correctly the callback send_SGI

2015-05-21 Thread Ian Campbell
On Sat, 2015-05-09 at 21:13 +0800, Chen Baozi wrote: On Fri, May 08, 2015 at 06:01:12PM +0100, Julien Grall wrote: Currently, the GICv3 driver is only able to send an SGI when the cpumask is provided. Although with the modes SGI_TARGET_OTHERS and SGI_TARGET_SELF, no cpumask is provided. Any

Re: [Xen-devel] [PATCH] xen/arm: gic-v3: Implement correctly the callback send_SGI

2015-05-11 Thread Ian Campbell
On Fri, 2015-05-08 at 17:55 +0100, Julien Grall wrote: Hi Ian, On 08/05/15 16:51, Ian Campbell wrote: On Fri, 2015-05-08 at 15:34 +0100, Julien Grall wrote: On 08/05/15 15:01, Ian Campbell wrote: I think you should just cast to uint64_t and WRITE_SYSREG64. Right, I blindly re-use the

Re: [Xen-devel] [PATCH] xen/arm: gic-v3: Implement correctly the callback send_SGI

2015-05-09 Thread Chen Baozi
On Fri, May 08, 2015 at 06:01:12PM +0100, Julien Grall wrote: Currently, the GICv3 driver is only able to send an SGI when the cpumask is provided. Although with the modes SGI_TARGET_OTHERS and SGI_TARGET_SELF, no cpumask is provided. Any usage of those modes will crash the hypersivor.

Re: [Xen-devel] [PATCH] xen/arm: gic-v3: Implement correctly the callback send_SGI

2015-05-08 Thread Ian Campbell
On Tue, 2015-04-28 at 11:31 +0100, Julien Grall wrote: Hi Stefano, On 28/04/15 11:00, Stefano Stabellini wrote: On Mon, 27 Apr 2015, Julien Grall wrote: diff --git a/xen/include/asm-arm/gic_v3_defs.h b/xen/include/asm-arm/gic_v3_defs.h index b8a1c2e..556f114 100644 ---

Re: [Xen-devel] [PATCH] xen/arm: gic-v3: Implement correctly the callback send_SGI

2015-05-08 Thread Julien Grall
On 08/05/15 15:02, Ian Campbell wrote: On Tue, 2015-04-28 at 11:31 +0100, Julien Grall wrote: Hi Stefano, On 28/04/15 11:00, Stefano Stabellini wrote: On Mon, 27 Apr 2015, Julien Grall wrote: diff --git a/xen/include/asm-arm/gic_v3_defs.h b/xen/include/asm-arm/gic_v3_defs.h index

Re: [Xen-devel] [PATCH] xen/arm: gic-v3: Implement correctly the callback send_SGI

2015-05-08 Thread Julien Grall
Hi Ian, On 08/05/15 15:01, Ian Campbell wrote: On Mon, 2015-04-27 at 19:31 +0100, Julien Grall wrote: Currently, the GICv3 drivers is only able to send an SGI when the cpumask driver is provided. Although with the modes SGI_TARGET_OTHERS and SGI_TARGET_SELF, no cpumask is provided. Any

Re: [Xen-devel] [PATCH] xen/arm: gic-v3: Implement correctly the callback send_SGI

2015-05-08 Thread Ian Campbell
On Mon, 2015-04-27 at 19:31 +0100, Julien Grall wrote: Currently, the GICv3 drivers is only able to send an SGI when the cpumask driver is provided. Although with the modes SGI_TARGET_OTHERS and SGI_TARGET_SELF, no cpumask is provided. Any usage of those modes will crash the hypersivor.

[Xen-devel] [PATCH] xen/arm: gic-v3: Implement correctly the callback send_SGI

2015-05-08 Thread Julien Grall
Currently, the GICv3 driver is only able to send an SGI when the cpumask is provided. Although with the modes SGI_TARGET_OTHERS and SGI_TARGET_SELF, no cpumask is provided. Any usage of those modes will crash the hypersivor. Rename gicv3_send_sgi to gicv3_send_sgi_list and implement the different

Re: [Xen-devel] [PATCH] xen/arm: gic-v3: Implement correctly the callback send_SGI

2015-05-08 Thread Ian Campbell
On Fri, 2015-05-08 at 15:34 +0100, Julien Grall wrote: Hi Ian, On 08/05/15 15:01, Ian Campbell wrote: On Mon, 2015-04-27 at 19:31 +0100, Julien Grall wrote: Currently, the GICv3 drivers is only able to send an SGI when the cpumask driver is provided. Although with the modes

Re: [Xen-devel] [PATCH] xen/arm: gic-v3: Implement correctly the callback send_SGI

2015-05-08 Thread Ian Campbell
On Fri, 2015-05-08 at 15:27 +0100, Julien Grall wrote: On 08/05/15 15:02, Ian Campbell wrote: On Tue, 2015-04-28 at 11:31 +0100, Julien Grall wrote: Hi Stefano, On 28/04/15 11:00, Stefano Stabellini wrote: On Mon, 27 Apr 2015, Julien Grall wrote: diff --git

Re: [Xen-devel] [PATCH] xen/arm: gic-v3: Implement correctly the callback send_SGI

2015-05-08 Thread Julien Grall
Hi Ian, On 08/05/15 16:51, Ian Campbell wrote: On Fri, 2015-05-08 at 15:34 +0100, Julien Grall wrote: On 08/05/15 15:01, Ian Campbell wrote: I think you should just cast to uint64_t and WRITE_SYSREG64. Right, I blindly re-use the WRITE_SYSREG as it was done on the previous implementation.

Re: [Xen-devel] [PATCH] xen/arm: gic-v3: Implement correctly the callback send_SGI

2015-04-28 Thread Julien Grall
Hi Stefano, On 28/04/15 11:00, Stefano Stabellini wrote: On Mon, 27 Apr 2015, Julien Grall wrote: diff --git a/xen/include/asm-arm/gic_v3_defs.h b/xen/include/asm-arm/gic_v3_defs.h index b8a1c2e..556f114 100644 --- a/xen/include/asm-arm/gic_v3_defs.h +++ b/xen/include/asm-arm/gic_v3_defs.h

Re: [Xen-devel] [PATCH] xen/arm: gic-v3: Implement correctly the callback send_SGI

2015-04-28 Thread Stefano Stabellini
On Mon, 27 Apr 2015, Julien Grall wrote: Currently, the GICv3 drivers is only able to send an SGI when the cpumask is provided. Although with the modes SGI_TARGET_OTHERS and SGI_TARGET_SELF, no cpumask is provided. Any usage of those modes will crash the hypersivor. Move the rename

[Xen-devel] [PATCH] xen/arm: gic-v3: Implement correctly the callback send_SGI

2015-04-27 Thread Julien Grall
Currently, the GICv3 drivers is only able to send an SGI when the cpumask is provided. Although with the modes SGI_TARGET_OTHERS and SGI_TARGET_SELF, no cpumask is provided. Any usage of those modes will crash the hypersivor. Move the rename gicv3_send_sgi to gicv3_send_sgi_list and implement the