Re: [Xen-devel] [PATCH] xen/blkback: use rb_entry()

2016-12-20 Thread Konrad Rzeszutek Wilk
On Tue, Dec 20, 2016 at 01:53:21PM -0800, Eric Dumazet wrote: > On Tue, 2016-12-20 at 12:51 -0500, Konrad Rzeszutek Wilk wrote: > > On Tue, Dec 20, 2016 at 05:44:06PM +, Roger Pau Monné wrote: > > > On Tue, Dec 20, 2016 at 11:47:03AM -0500, Konrad Rzeszutek Wilk wrote: > > > > On Tue, Dec 20, 2

Re: [Xen-devel] [PATCH] xen/blkback: use rb_entry()

2016-12-20 Thread Eric Dumazet
On Tue, 2016-12-20 at 12:51 -0500, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 20, 2016 at 05:44:06PM +, Roger Pau Monné wrote: > > On Tue, Dec 20, 2016 at 11:47:03AM -0500, Konrad Rzeszutek Wilk wrote: > > > On Tue, Dec 20, 2016 at 10:02:19PM +0800, Geliang Tang wrote: > > > > To make the code

Re: [Xen-devel] [PATCH] xen/blkback: use rb_entry()

2016-12-20 Thread Konrad Rzeszutek Wilk
On Tue, Dec 20, 2016 at 05:44:06PM +, Roger Pau Monné wrote: > On Tue, Dec 20, 2016 at 11:47:03AM -0500, Konrad Rzeszutek Wilk wrote: > > On Tue, Dec 20, 2016 at 10:02:19PM +0800, Geliang Tang wrote: > > > To make the code clearer, use rb_entry() instead of container_of() to > > > deal with rbt

Re: [Xen-devel] [PATCH] xen/blkback: use rb_entry()

2016-12-20 Thread Roger Pau Monné
On Tue, Dec 20, 2016 at 11:47:03AM -0500, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 20, 2016 at 10:02:19PM +0800, Geliang Tang wrote: > > To make the code clearer, use rb_entry() instead of container_of() to > > deal with rbtree. > > That is OK but I think 'container_of' is more clear. > > Roger

Re: [Xen-devel] [PATCH] xen/blkback: use rb_entry()

2016-12-20 Thread Konrad Rzeszutek Wilk
On Tue, Dec 20, 2016 at 10:02:19PM +0800, Geliang Tang wrote: > To make the code clearer, use rb_entry() instead of container_of() to > deal with rbtree. That is OK but I think 'container_of' is more clear. Roger, thoughts? > > Signed-off-by: Geliang Tang > --- > drivers/block/xen-blkback/blk

[Xen-devel] [PATCH] xen/blkback: use rb_entry()

2016-12-20 Thread Geliang Tang
To make the code clearer, use rb_entry() instead of container_of() to deal with rbtree. Signed-off-by: Geliang Tang --- drivers/block/xen-blkback/blkback.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback