Re: [Xen-devel] [PATCH 0/4] dma-mapping: Constify dma_attrs

2016-05-25 Thread Krzysztof Kozlowski
On 05/24/2016 11:09 AM, Christoph Hellwig wrote: > I think this is moving into the wrong direction. The right fix here > is to get of all the dma_attrs boilerplate code and just replace it > with a simple enum dma_flags. This would simplify both the callers > and most importantly the wrappers

Re: [Xen-devel] [PATCH 0/4] dma-mapping: Constify dma_attrs

2016-05-24 Thread Christoph Hellwig
I think this is moving into the wrong direction. The right fix here is to get of all the dma_attrs boilerplate code and just replace it with a simple enum dma_flags. This would simplify both the callers and most importantly the wrappers for the flag-less versions a lot.

[Xen-devel] [PATCH 0/4] dma-mapping: Constify dma_attrs

2016-05-24 Thread Krzysztof Kozlowski
Hi, The patchset is divided into two parts: 1. (patch 1-3): Constify dma_attrs passed to some of functions. The first patch is a dependency for all other. This is not intrusive. 2. patch 4: request for comments, constify dma_attrs everywhere (struct dma_map_ops and implementations).