Sure, I will continue to send revisions until it is approved upstream.
On Jul 22, 2016 5:24 PM, "Quan Xu" wrote:
> Anthony, thanks for your explaination.
> IMO, patch 1 and patch 2 need your detailed review.. IMO the reset
> patches are good in general..
> Emil, if patch 1
Anthony, thanks for your explaination.IMO, patch 1 and patch 2 need your
detailed review.. IMO the reset patches are good in general..Emil, if patch 1 /
patch 2 are reviewed from anthony, could you send out v10? :) i know it's not
an easy task, thanks in advence!!
Quan
On Mon, 18 Jul 2016
rix.com>; stefanb <stef...@linux.vnet.ibm.com>; anthony.perard
<anthony.per...@citrix.com>Subject:Re: [Xen-devel] [PATCH 01/19] xen: Create a
new file xen_pvdev.c
Eric, this is the link to the original patch which is well formatted:
http://marc.info/?l=xen-devel=146815138831762=2I
Eric, this is the link to the original patch which is well formatted:
http://marc.info/?l=xen-devel=146815138831762=2
I think that the formatting and s-o-b was broken in the reply from Quan.
On Jul 18, 2016 17:57, "Eric Blake" wrote:
> On 07/17/2016 01:41 AM, Quan Xu wrote:
>
On 07/17/2016 01:41 AM, Quan Xu wrote:
>
> [Quan:]: comment starts with [Quan:]
>
This line doesn't belong in a commit message; it's fine to put it after
the --- separator though, if it aids mailing list reviewers.
>
> The purpose of the new file is to store generic functions shared by
>
On Sun, Jul 17, 2016 at 03:41:26PM +0800, Quan Xu wrote:
>
> [Quan:]: comment starts with [Quan:]
>
>
> The purpose of the new file is to store generic functions shared by
> frontendand backends such as xenstore operations, xendevs.
>
> Signed-off-by: Quan Xu
>
On Jul 17, 2016 10:41, "Quan Xu" wrote:
>
>
> [Quan:]: comment starts with [Quan:]
>
Thanks, Quan for your comments.
The first patches from this series just move some code from xen_backend to
xen_pvdev file. I would not group the reorg from xen_backend with
refactoring in
[Quan:]: comment starts with [Quan:]
The purpose of the new file is to store generic functions shared by frontendand
backends such as xenstore operations, xendevs.
Signed-off-by: Quan Xu
Signed-off-by: Emil Condrea
---
hw/xen/Makefile.objs
The purpose of the new file is to store generic functions shared by frontend
and backends such as xenstore operations, xendevs.
Signed-off-by: Quan Xu
Signed-off-by: Emil Condrea
---
hw/xen/Makefile.objs | 2 +-
hw/xen/xen_backend.c |