Re: [Xen-devel] [PATCH 01/27] xen/x86: numa: Don't check alloc_boot_pages return

2017-08-22 Thread Andre Przywara
Hi, On 14/08/17 15:23, Julien Grall wrote: > alloc_boot_pages will panic if it is not possible to allocate. So the > check in the caller is pointless. More than that I don't see why "0" couldn't be a valid MFN. At least the code in alloc_boot_pages() doesn't treat it specially, so it doesn't sign

[Xen-devel] [PATCH 01/27] xen/x86: numa: Don't check alloc_boot_pages return

2017-08-14 Thread Julien Grall
alloc_boot_pages will panic if it is not possible to allocate. So the check in the caller is pointless. Signed-off-by: Julien Grall --- Cc: Jan Beulich Cc: Andrew Cooper --- xen/arch/x86/numa.c | 8 1 file changed, 8 deletions(-) diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.