Re: [Xen-devel] [PATCH 03/27] xen/x86: mm: Don't check alloc_boot_pages return

2017-08-22 Thread Julien Grall
On 22/08/17 12:28, Andre Przywara wrote: Hi, Hi Andre, On 14/08/17 15:23, Julien Grall wrote: The only way alloc_boot_pages will return 0 is during the error case. This statement is not true. If alloc_boot_pages() returns, it has succeeded. Returning 0 is nothing special. Although, Xe

Re: [Xen-devel] [PATCH 03/27] xen/x86: mm: Don't check alloc_boot_pages return

2017-08-22 Thread Andre Przywara
Hi, On 14/08/17 15:23, Julien Grall wrote: > The only way alloc_boot_pages will return 0 is during the error case. This statement is not true. If alloc_boot_pages() returns, it has succeeded. Returning 0 is nothing special. > Although, Xen will panic in the error path. So the check in the caller

Re: [Xen-devel] [PATCH 03/27] xen/x86: mm: Don't check alloc_boot_pages return

2017-08-15 Thread Jan Beulich
>>> On 14.08.17 at 16:23, wrote: > The only way alloc_boot_pages will return 0 is during the error case. > Although, Xen will panic in the error path. So the check in the caller > is pointless. > > Looking at the loop, my understanding is it will try to allocate in > smaller chunk if a bigger chu

[Xen-devel] [PATCH 03/27] xen/x86: mm: Don't check alloc_boot_pages return

2017-08-14 Thread Julien Grall
The only way alloc_boot_pages will return 0 is during the error case. Although, Xen will panic in the error path. So the check in the caller is pointless. Looking at the loop, my understanding is it will try to allocate in smaller chunk if a bigger chunk fail. Given that alloc_boot_pages can never