Re: [Xen-devel] [PATCH 1/2] hvmloader: correctly copy signature to info structures

2016-08-19 Thread Jan Beulich
>>> On 19.08.16 at 11:42, wrote: > On 19/08/16 09:25, Jan Beulich wrote: > On 19.08.16 at 10:06, wrote: >>> --- a/tools/firmware/hvmloader/ovmf.c >>> +++ b/tools/firmware/hvmloader/ovmf.c >>> @@ -67,10 +67,11 @@ struct ovmf_info { >>> static

Re: [Xen-devel] [PATCH 1/2] hvmloader: correctly copy signature to info structures

2016-08-19 Thread Andrew Cooper
On 19/08/16 09:25, Jan Beulich wrote: On 19.08.16 at 10:06, wrote: >> --- a/tools/firmware/hvmloader/ovmf.c >> +++ b/tools/firmware/hvmloader/ovmf.c >> @@ -67,10 +67,11 @@ struct ovmf_info { >> static void ovmf_setup_bios_info(void) >> { >> struct ovmf_info *info

Re: [Xen-devel] [PATCH 1/2] hvmloader: correctly copy signature to info structures

2016-08-19 Thread Jan Beulich
>>> On 19.08.16 at 10:06, wrote: > --- a/tools/firmware/hvmloader/ovmf.c > +++ b/tools/firmware/hvmloader/ovmf.c > @@ -67,10 +67,11 @@ struct ovmf_info { > static void ovmf_setup_bios_info(void) > { > struct ovmf_info *info = (void *)OVMF_INFO_PHYSICAL_ADDRESS; > +

[Xen-devel] [PATCH 1/2] hvmloader: correctly copy signature to info structures

2016-08-19 Thread Wei Liu
The original code used sizeof(info->signature) as the size parameter for memcpy, which was wrong. Fix that by calculating the correct size. Signed-off-by: Wei Liu --- tools/firmware/hvmloader/ovmf.c| 3 ++- tools/firmware/hvmloader/seabios.c | 3 ++- 2 files changed, 4