Re: [Xen-devel] [PATCH 1/2] xen/arm64: correct comments

2016-04-22 Thread Julien Grall
Hello Peng, I would specific the file modified in the title. On 20/04/16 14:54, Peng Fan wrote: The 'Base address for 4K mapping' is '(x19 >> THIRD_SHIFT) << THIRD_SHIFT'. The computation is a sequence of 2 instructions. I gave a look to the rest of the file and the comments are usually put

[Xen-devel] [PATCH 1/2] xen/arm64: correct comments

2016-04-20 Thread Peng Fan
The 'Base address for 4K mapping' is '(x19 >> THIRD_SHIFT) << THIRD_SHIFT'. Also we are building 4K page mapping, not section mapping. Signed-off-by: Peng Fan Cc: Stefano Stabellini Cc: Julien Grall ---