Re: [Xen-devel] [PATCH 1/6] xen-blkfront: avoid to use start/stop queue

2017-07-11 Thread Ming Lei
On Tue, Jul 11, 2017 at 06:41:29PM +, Bart Van Assche wrote: > On Wed, 2017-07-12 at 02:20 +0800, Ming Lei wrote: > > This interfaces will be removed soon, so use quiesce and > > unquiesce instead, which should be more safe. > > > > The only one usage will be removed in the following > >

[Xen-devel] [PATCH 1/6] xen-blkfront: avoid to use start/stop queue

2017-07-11 Thread Ming Lei
This interfaces will be removed soon, so use quiesce and unquiesce instead, which should be more safe. The only one usage will be removed in the following congestion control patches. Cc: Konrad Rzeszutek Wilk Cc: "Roger Pau Monné" Cc: Boris

Re: [Xen-devel] [PATCH 1/6] xen-blkfront: avoid to use start/stop queue

2017-07-11 Thread Bart Van Assche
On Wed, 2017-07-12 at 02:20 +0800, Ming Lei wrote: > This interfaces will be removed soon, so use quiesce and > unquiesce instead, which should be more safe. > > The only one usage will be removed in the following > congestion control patches. Hello Ming, The title of this patch is misleading

Re: [Xen-devel] [PATCH 1/6] xen-blkfront: avoid to use start/stop queue

2017-07-11 Thread Ming Lei
On Tue, Jul 11, 2017 at 02:41:05PM -0400, Konrad Rzeszutek Wilk wrote: > On Wed, Jul 12, 2017 at 02:20:58AM +0800, Ming Lei wrote: > > This interfaces will be removed soon, so use quiesce and > > unquiesce instead, which should be more safe. > > 'should be'? That does not sound encouraging?

Re: [Xen-devel] [PATCH 1/6] xen-blkfront: avoid to use start/stop queue

2017-07-11 Thread Ming Lei
On Tue, Jul 11, 2017 at 11:24:44PM +0200, Roger Pau Monné wrote: > On Wed, Jul 12, 2017 at 02:20:58AM +0800, Ming Lei wrote: > > This interfaces will be removed soon, so use quiesce and > > unquiesce instead, which should be more safe. > > > > The only one usage will be removed in the following >

Re: [Xen-devel] [PATCH 1/6] xen-blkfront: avoid to use start/stop queue

2017-07-11 Thread Ming Lei
On Tue, Jul 11, 2017 at 06:41:29PM +, Bart Van Assche wrote: > On Wed, 2017-07-12 at 02:20 +0800, Ming Lei wrote: > > This interfaces will be removed soon, so use quiesce and > > unquiesce instead, which should be more safe. > > > > The only one usage will be removed in the following > >

Re: [Xen-devel] [PATCH 1/6] xen-blkfront: avoid to use start/stop queue

2017-07-11 Thread Roger Pau Monné
On Wed, Jul 12, 2017 at 02:20:58AM +0800, Ming Lei wrote: > This interfaces will be removed soon, so use quiesce and > unquiesce instead, which should be more safe. > > The only one usage will be removed in the following > congestion control patches. Would it be better to simply fix

Re: [Xen-devel] [PATCH 1/6] xen-blkfront: avoid to use start/stop queue

2017-07-11 Thread Konrad Rzeszutek Wilk
On Wed, Jul 12, 2017 at 02:20:58AM +0800, Ming Lei wrote: > This interfaces will be removed soon, so use quiesce and > unquiesce instead, which should be more safe. 'should be'? That does not sound encouraging? > > The only one usage will be removed in the following > congestion control