Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-09-15 Thread George Dunlap
On Mon, Sep 14, 2015 at 7:33 PM, Olaf Hering wrote: > On Mon, Sep 14, George Dunlap wrote: > >> Well if you "know nothing about SELinux", and you don't use it, and >> don't have any test systems that use it, then why did you assert >> "The proper place to specify [an SELinux mount

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-09-15 Thread George Dunlap
On 09/15/2015 04:12 PM, Konrad Rzeszutek Wilk wrote: > On Tue, Sep 15, 2015 at 03:01:31PM +0100, George Dunlap wrote: >> On 09/15/2015 02:58 PM, Konrad Rzeszutek Wilk wrote: >>> On Tue, Sep 15, 2015 at 01:55:15PM +0100, George Dunlap wrote: On Tue, Sep 15, 2015 at 1:48 PM, Olaf Hering

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-09-15 Thread Konrad Rzeszutek Wilk
On Tue, Sep 15, 2015 at 03:01:31PM +0100, George Dunlap wrote: > On 09/15/2015 02:58 PM, Konrad Rzeszutek Wilk wrote: > > On Tue, Sep 15, 2015 at 01:55:15PM +0100, George Dunlap wrote: > >> On Tue, Sep 15, 2015 at 1:48 PM, Olaf Hering wrote: > >>> On Tue, Sep 15, George Dunlap

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-09-15 Thread Konrad Rzeszutek Wilk
On Tue, Sep 15, 2015 at 02:48:57PM +0200, Olaf Hering wrote: > On Tue, Sep 15, George Dunlap wrote: > > > It's very reasonable for you to expect it to be fixed on non-SELinux > > systems. But what you did is fix it for non-SELinux systems by simply > > breaking it on SELinux systems -- that's

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-09-15 Thread Konrad Rzeszutek Wilk
On Tue, Sep 15, 2015 at 01:55:15PM +0100, George Dunlap wrote: > On Tue, Sep 15, 2015 at 1:48 PM, Olaf Hering wrote: > > On Tue, Sep 15, George Dunlap wrote: > > > >> It's very reasonable for you to expect it to be fixed on non-SELinux > >> systems. But what you did is fix it for

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-09-15 Thread George Dunlap
On 09/15/2015 02:58 PM, Konrad Rzeszutek Wilk wrote: > On Tue, Sep 15, 2015 at 01:55:15PM +0100, George Dunlap wrote: >> On Tue, Sep 15, 2015 at 1:48 PM, Olaf Hering wrote: >>> On Tue, Sep 15, George Dunlap wrote: >>> It's very reasonable for you to expect it to be fixed on

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-09-15 Thread Olaf Hering
On Tue, Sep 15, George Dunlap wrote: > It's very reasonable for you to expect it to be fixed on non-SELinux > systems. But what you did is fix it for non-SELinux systems by simply > breaking it on SELinux systems -- that's not at all reasonable. Konrad did some testing at that time and said 4.5

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-09-15 Thread George Dunlap
On Tue, Sep 15, 2015 at 1:48 PM, Olaf Hering wrote: > On Tue, Sep 15, George Dunlap wrote: > >> It's very reasonable for you to expect it to be fixed on non-SELinux >> systems. But what you did is fix it for non-SELinux systems by simply >> breaking it on SELinux systems --

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-09-14 Thread George Dunlap
On 09/11/2015 07:31 AM, Olaf Hering wrote: > On Thu, Sep 10, George Dunlap wrote: > >> On Fri, Dec 19, 2014 at 11:25 AM, Olaf Hering wrote: >>> Using SELinux mount options per default breaks several systems. >>> Either the context= mount option is not known at all to the kernel,

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-09-14 Thread Olaf Hering
On Mon, Sep 14, George Dunlap wrote: > Well if you "know nothing about SELinux", and you don't use it, and > don't have any test systems that use it, then why did you assert > "The proper place to specify [an SELinux mount context] is /etc/fstab"? > This patchset was accepted because you

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-09-11 Thread Olaf Hering
On Thu, Sep 10, George Dunlap wrote: > On Fri, Dec 19, 2014 at 11:25 AM, Olaf Hering wrote: > > Using SELinux mount options per default breaks several systems. > > Either the context= mount option is not known at all to the kernel, > > as reported for ArchLinux. Or the default

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-09-10 Thread M A Young
On Thu, 10 Sep 2015, George Dunlap wrote: > On Fri, Dec 19, 2014 at 11:25 AM, Olaf Hering wrote: > > Using SELinux mount options per default breaks several systems. > > Either the context= mount option is not known at all to the kernel, > > as reported for ArchLinux. Or the

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-09-10 Thread George Dunlap
On 09/10/2015 03:13 PM, M A Young wrote: > On Thu, 10 Sep 2015, George Dunlap wrote: > >> On Fri, Dec 19, 2014 at 11:25 AM, Olaf Hering wrote: >>> Using SELinux mount options per default breaks several systems. >>> Either the context= mount option is not known at all to the

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-01-07 Thread Olaf Hering
On Tue, Jan 06, Ian Campbell wrote: On Fri, 2014-12-19 at 12:25 +0100, Olaf Hering wrote: ... Acked-by: Ian Campbell ian.campb...@citrix.com (on commit s/Appearently/Apparently/; s/non-existant/non-existent/ in the commit log) I made typos also in other commit messages. Should I resend

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-01-07 Thread Konrad Rzeszutek Wilk
On Wed, Jan 07, 2015 at 09:31:50AM +, Ian Campbell wrote: On Wed, 2015-01-07 at 10:23 +0100, Olaf Hering wrote: On Tue, Jan 06, Ian Campbell wrote: On Fri, 2014-12-19 at 12:25 +0100, Olaf Hering wrote: ... Acked-by: Ian Campbell ian.campb...@citrix.com (on commit

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-01-06 Thread Ian Campbell
On Fri, 2014-12-19 at 12:25 +0100, Olaf Hering wrote: Using SELinux mount options per default breaks several systems. Either the context= mount option is not known at all to the kernel, as reported for ArchLinux. Or the default value none is unknown to SELinux, as reported for Fedora. In both

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-01-06 Thread Ian Jackson
Olaf Hering writes ([PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount): Using SELinux mount options per default breaks several systems. Either the context= mount option is not known at all to the kernel, as reported for ArchLinux. Or the default value none is

[Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2014-12-19 Thread Olaf Hering
Using SELinux mount options per default breaks several systems. Either the context= mount option is not known at all to the kernel, as reported for ArchLinux. Or the default value none is unknown to SELinux, as reported for Fedora. In both cases the unit will fail. The proper place to specify