Re: [Xen-devel] [PATCH 11/27] x86/hvm: Improve hvm_efer_valid() using named features

2017-01-05 Thread Andrew Cooper
On 05/01/17 11:34, Jan Beulich wrote: On 04.01.17 at 13:39, wrote: >> --- a/xen/arch/x86/hvm/hvm.c >> +++ b/xen/arch/x86/hvm/hvm.c >> @@ -914,56 +914,35 @@ static int hvm_save_cpu_ctxt(struct domain *d, >> hvm_domain_context_t *h) >> } >> >> /* Return a string indicating the error, or NU

Re: [Xen-devel] [PATCH 11/27] x86/hvm: Improve hvm_efer_valid() using named features

2017-01-05 Thread Jan Beulich
>>> On 04.01.17 at 13:39, wrote: > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -914,56 +914,35 @@ static int hvm_save_cpu_ctxt(struct domain *d, > hvm_domain_context_t *h) > } > > /* Return a string indicating the error, or NULL for valid. */ > -const char *hvm_efer_valid

[Xen-devel] [PATCH 11/27] x86/hvm: Improve hvm_efer_valid() using named features

2017-01-04 Thread Andrew Cooper
Pick the appropriate cpuid_policy object rather than using hvm_cpuid() or boot_cpu_data. This breaks the dependency on current. As data is read straight out of cpuid_policy, there is no need to work around the fact that X86_FEATURE_SYSCALL might be clear because of the dynamic adjustment in hvm_c