Re: [Xen-devel] [PATCH 2/2] libxl: fix UUID usage on FreeBSD

2016-01-19 Thread Ian Jackson
Ian Campbell writes ("Re: [Xen-devel] [PATCH 2/2] libxl: fix UUID usage on FreeBSD"): > On Fri, 2016-01-15 at 16:11 +0100, Roger Pau Monné wrote: > > Yes, we can remove the uuid_t from libxl_uuid, but this is AFAICT a > > structure that belongs to the stable API. >

Re: [Xen-devel] [PATCH 2/2] libxl: fix UUID usage on FreeBSD

2016-01-15 Thread Ian Campbell
On Fri, 2016-01-15 at 16:11 +0100, Roger Pau Monné wrote: > El 15/01/16 a les 11.26, Ian Campbell ha escrit: > > On Tue, 2016-01-12 at 14:14 +0100, Roger Pau Monne wrote: > > > libxl makes the assumtion that libxl_uuid == uuid_t, > > > > ("assumption") > > > > >  and that uuid_t can be > > > free

Re: [Xen-devel] [PATCH 2/2] libxl: fix UUID usage on FreeBSD

2016-01-15 Thread Roger Pau Monné
El 15/01/16 a les 11.26, Ian Campbell ha escrit: > On Tue, 2016-01-12 at 14:14 +0100, Roger Pau Monne wrote: >> libxl makes the assumtion that libxl_uuid == uuid_t, > > ("assumption") > >> and that uuid_t can be >> freely used as a byte array. This is not true on FreeBSD (and NetBSD >> too, not

Re: [Xen-devel] [PATCH 2/2] libxl: fix UUID usage on FreeBSD

2016-01-15 Thread Ian Campbell
On Tue, 2016-01-12 at 14:14 +0100, Roger Pau Monne wrote: > libxl makes the assumtion that libxl_uuid == uuid_t, ("assumption") > and that uuid_t can be > freely used as a byte array. This is not true on FreeBSD (and NetBSD > too, not sure about other BSD UUID implementations), where the interna

[Xen-devel] [PATCH 2/2] libxl: fix UUID usage on FreeBSD

2016-01-12 Thread Roger Pau Monne
libxl makes the assumtion that libxl_uuid == uuid_t, and that uuid_t can be freely used as a byte array. This is not true on FreeBSD (and NetBSD too, not sure about other BSD UUID implementations), where the internals of uuid don't match what libxl expects as a byte array because of endianness issu