Re: [Xen-devel] [PATCH 2/2] x86emul: in_longmode() should not ignore ->read_msr() errors

2016-11-22 Thread Andrew Cooper
On 22/11/16 14:20, Jan Beulich wrote: > Suggested-by: George Dunlap > Signed-off-by: Jan Beulich Possibly worth nothing in the commit message that the current implementation of this hook when present never fails with MSR_EFER? Reviewed-by: Andrew

[Xen-devel] [PATCH 2/2] x86emul: in_longmode() should not ignore ->read_msr() errors

2016-11-22 Thread Jan Beulich
Suggested-by: George Dunlap Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -1296,10 +1296,10 @@ in_longmode( { uint64_t efer; -if (ops->read_msr == NULL) +if (