Re: [Xen-devel] [PATCH 2/3] gnttab: Drop the frame parameter from get_paged_frame()

2017-08-25 Thread Wei Liu
On Fri, Aug 25, 2017 at 10:38:19AM +0100, Andrew Cooper wrote: > >> +*page = mfn_valid(mfn) ? mfn_to_page(mfn_x(mfn)) : NULL; > >> if ( (!(*page)) || (!get_page(*page, rd)) ) > > Mind dropping those unneeded parentheses? > > I'm planning separate cleanup to this function (including

Re: [Xen-devel] [PATCH 2/3] gnttab: Drop the frame parameter from get_paged_frame()

2017-08-25 Thread Andrew Cooper
On 25/08/17 10:02, Wei Liu wrote: > On Thu, Aug 24, 2017 at 06:55:54PM +0100, Andrew Cooper wrote: >> It is redundant with the *page parameter. >> >> Signed-off-by: Andrew Cooper > Reviewed-by: Wei Liu Thanks. > >> --- >> CC: George Dunlap

Re: [Xen-devel] [PATCH 2/3] gnttab: Drop the frame parameter from get_paged_frame()

2017-08-25 Thread Wei Liu
On Thu, Aug 24, 2017 at 06:55:54PM +0100, Andrew Cooper wrote: > It is redundant with the *page parameter. > > Signed-off-by: Andrew Cooper Reviewed-by: Wei Liu > --- > CC: George Dunlap > CC: Jan Beulich

[Xen-devel] [PATCH 2/3] gnttab: Drop the frame parameter from get_paged_frame()

2017-08-24 Thread Andrew Cooper
It is redundant with the *page parameter. Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Jan Beulich CC: Konrad Rzeszutek Wilk CC: Stefano Stabellini CC: Tim