Re: [Xen-devel] [PATCH 2/3] xen: slightly simplify bufioreq handling

2016-11-24 Thread Jan Beulich
>>> On 23.11.16 at 19:13, wrote: > On Wed, 23 Nov 2016, Jan Beulich wrote: >> There's no point setting fields always receiving the same value on each >> iteration, as handle_ioreq() doesn't alter them anyway. Set state and >> count once ahead of the loop, drop the

Re: [Xen-devel] [PATCH 2/3] xen: slightly simplify bufioreq handling

2016-11-23 Thread Stefano Stabellini
On Wed, 23 Nov 2016, Jan Beulich wrote: > There's no point setting fields always receiving the same value on each > iteration, as handle_ioreq() doesn't alter them anyway. Set state and > count once ahead of the loop, drop the redundant clearing of > data_is_ptr, and avoid the meaningless setting

Re: [Xen-devel] [PATCH 2/3] xen: slightly simplify bufioreq handling

2016-11-23 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 23 November 2016 09:25 > To: qemu-de...@nongnu.org > Cc: Anthony Perard ; Paul Durrant > ; Stefano Stabellini ; xen- > devel

[Xen-devel] [PATCH 2/3] xen: slightly simplify bufioreq handling

2016-11-23 Thread Jan Beulich
There's no point setting fields always receiving the same value on each iteration, as handle_ioreq() doesn't alter them anyway. Set state and count once ahead of the loop, drop the redundant clearing of data_is_ptr, and avoid the meaningless setting of df altogether. Also avoid doing an unsigned