Re: [Xen-devel] [PATCH 26/27 v8] xen/arm: vpl011: Correct the logic for asserting/de-asserting SBSA UART TX interrupt

2017-09-12 Thread Julien Grall
Hi Bhupinder, I am just commenting on the commit message, Andre already commented the code. On 28/08/17 09:56, Bhupinder Thakur wrote: This patch fixes the issue observed when pl011 patches were tested on the junos hardware by Andre/Julien. It was observed that when large output is generated

Re: [Xen-devel] [PATCH 26/27 v8] xen/arm: vpl011: Correct the logic for asserting/de-asserting SBSA UART TX interrupt

2017-09-12 Thread Julien Grall
Hi, On 07/09/17 15:37, Andre Przywara wrote: vpl011->uartfr |= BUSY; @@ -368,7 +376,16 @@ static void vpl011_data_avail(struct domain *d) if ( out_ring_qsize != sizeof(intf->out) ) { vpl011->uartfr &= ~TXFF; -vpl011->uartris |= TXI; + +/* +

Re: [Xen-devel] [PATCH 26/27 v8] xen/arm: vpl011: Correct the logic for asserting/de-asserting SBSA UART TX interrupt

2017-09-11 Thread Bhupinder Thakur
Hi Andre, >> diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c >> index 56d9cbe..1e72fca 100644 >> --- a/xen/arch/arm/vpl011.c >> +++ b/xen/arch/arm/vpl011.c >> @@ -152,12 +152,20 @@ static void vpl011_write_data(struct domain *d, >> uint8_t data) >> else >> gprintk(XENLOG

Re: [Xen-devel] [PATCH 26/27 v8] xen/arm: vpl011: Correct the logic for asserting/de-asserting SBSA UART TX interrupt

2017-09-07 Thread Andre Przywara
Hi, On 28/08/17 09:56, Bhupinder Thakur wrote: > This patch fixes the issue observed when pl011 patches were tested on > the junos hardware by Andre/Julien. It was observed that when large output is > generated such as on running 'find /', output was getting truncated > intermittently > due to OU

[Xen-devel] [PATCH 26/27 v8] xen/arm: vpl011: Correct the logic for asserting/de-asserting SBSA UART TX interrupt

2017-08-28 Thread Bhupinder Thakur
This patch fixes the issue observed when pl011 patches were tested on the junos hardware by Andre/Julien. It was observed that when large output is generated such as on running 'find /', output was getting truncated intermittently due to OUT ring buffer getting full. This issue was due to the fac