Re: [Xen-devel] [PATCH 3/3] libxl: libxl__device_from_disk should retrieve backend from xenstore

2015-03-06 Thread Wei Liu
Sorry for the late reply. On Thu, Feb 26, 2015 at 04:49:21PM -0700, Jim Fehlig wrote: Wei Liu wrote: On Wed, Feb 11, 2015 at 10:18:18AM -0700, Jim Fehlig wrote: At minimum, libvirt will populate the pdev_path, vdev, backend, and format fields. If backend and format (which, in

Re: [Xen-devel] [PATCH 3/3] libxl: libxl__device_from_disk should retrieve backend from xenstore

2015-02-26 Thread Jim Fehlig
Wei Liu wrote: On Wed, Feb 11, 2015 at 10:18:18AM -0700, Jim Fehlig wrote: At minimum, libvirt will populate the pdev_path, vdev, backend, and format fields. If backend and format (which, in libvirt-speack correspond to the 'name' and 'type' attributes on the optional driver element) are

Re: [Xen-devel] [PATCH 3/3] libxl: libxl__device_from_disk should retrieve backend from xenstore

2015-02-23 Thread Wei Liu
On Wed, Feb 11, 2015 at 10:18:18AM -0700, Jim Fehlig wrote: Wei Liu wrote: On Tue, Feb 10, 2015 at 11:01:46AM +, Ian Jackson wrote: Wei Liu writes ([PATCH 3/3] libxl: libxl__device_from_disk should retrieve backend from xenstore): ... if backend is not set by caller.

Re: [Xen-devel] [PATCH 3/3] libxl: libxl__device_from_disk should retrieve backend from xenstore

2015-02-12 Thread Ian Jackson
Jim Fehlig writes (Re: [PATCH 3/3] libxl: libxl__device_from_disk should retrieve backend from xenstore): Wei Liu wrote: On Tue, Feb 10, 2015 at 11:01:46AM +, Ian Jackson wrote: What should happen if the caller specifies a different target in disk to the one the device is actually

Re: [Xen-devel] [PATCH 3/3] libxl: libxl__device_from_disk should retrieve backend from xenstore

2015-02-11 Thread Jim Fehlig
Wei Liu wrote: On Tue, Feb 10, 2015 at 11:01:46AM +, Ian Jackson wrote: Wei Liu writes ([PATCH 3/3] libxl: libxl__device_from_disk should retrieve backend from xenstore): ... if backend is not set by caller. Acked-by: Ian Jackson ian.jack...@eu.citrix.com as far as it

Re: [Xen-devel] [PATCH 3/3] libxl: libxl__device_from_disk should retrieve backend from xenstore

2015-02-10 Thread Wei Liu
On Tue, Feb 10, 2015 at 11:01:46AM +, Ian Jackson wrote: Wei Liu writes ([PATCH 3/3] libxl: libxl__device_from_disk should retrieve backend from xenstore): ... if backend is not set by caller. Acked-by: Ian Jackson ian.jack...@eu.citrix.com as far as it goes, but I think you may

[Xen-devel] [PATCH 3/3] libxl: libxl__device_from_disk should retrieve backend from xenstore

2015-02-09 Thread Wei Liu
... if backend is not set by caller. Also change the function to use goto idiom while I was there. Signed-off-by: Wei Liu wei.l...@citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com --- tools/libxl/libxl.c | 21 ++--- 1 file changed, 18