Re: [Xen-devel] [PATCH 3/3] x86/mm: Consolidate all Xen L4 slot writing into init_xen_l4_slots()

2017-10-18 Thread George Dunlap
On 10/12/2017 02:54 PM, Andrew Cooper wrote: > There are currently three functions which write L4 pagetables for Xen, but > they all behave subtly differently. sh_install_xen_entries_in_l4() in > particular is catering for two different usecases, which makes the safety of > the linear mappings

Re: [Xen-devel] [PATCH 3/3] x86/mm: Consolidate all Xen L4 slot writing into init_xen_l4_slots()

2017-10-12 Thread Jan Beulich
>>> On 12.10.17 at 17:24, wrote: > On 12/10/17 16:08, Jan Beulich wrote: > On 12.10.17 at 15:54, wrote: >>> --- a/xen/arch/x86/mm/hap/hap.c >>> +++ b/xen/arch/x86/mm/hap/hap.c >>> @@ -391,41 +391,24 @@ int hap_set_allocation(struct domain

Re: [Xen-devel] [PATCH 3/3] x86/mm: Consolidate all Xen L4 slot writing into init_xen_l4_slots()

2017-10-12 Thread Andrew Cooper
On 12/10/17 16:08, Jan Beulich wrote: On 12.10.17 at 15:54, wrote: >> --- a/xen/arch/x86/mm/hap/hap.c >> +++ b/xen/arch/x86/mm/hap/hap.c >> @@ -391,41 +391,24 @@ int hap_set_allocation(struct domain *d, unsigned int >> pages, bool *preempted) >> return 0; >>

Re: [Xen-devel] [PATCH 3/3] x86/mm: Consolidate all Xen L4 slot writing into init_xen_l4_slots()

2017-10-12 Thread Wei Liu
On Thu, Oct 12, 2017 at 02:54:22PM +0100, Andrew Cooper wrote: > There are currently three functions which write L4 pagetables for Xen, but > they all behave subtly differently. sh_install_xen_entries_in_l4() in > particular is catering for two different usecases, which makes the safety of > the

Re: [Xen-devel] [PATCH 3/3] x86/mm: Consolidate all Xen L4 slot writing into init_xen_l4_slots()

2017-10-12 Thread Jan Beulich
>>> On 12.10.17 at 15:54, wrote: > --- a/xen/arch/x86/mm/hap/hap.c > +++ b/xen/arch/x86/mm/hap/hap.c > @@ -391,41 +391,24 @@ int hap_set_allocation(struct domain *d, unsigned int > pages, bool *preempted) > return 0; > } > > -static void

[Xen-devel] [PATCH 3/3] x86/mm: Consolidate all Xen L4 slot writing into init_xen_l4_slots()

2017-10-12 Thread Andrew Cooper
There are currently three functions which write L4 pagetables for Xen, but they all behave subtly differently. sh_install_xen_entries_in_l4() in particular is catering for two different usecases, which makes the safety of the linear mappings hard to follow. By consolidating the L4 pagetable