Re: [Xen-devel] [PATCH 3/4] libxl/remus: Change the assert for info to an return

2016-02-01 Thread Wei Liu
On Tue, Jan 26, 2016 at 04:30:59PM -0500, Konrad Rzeszutek Wilk wrote: > The assert(info) is after quite a lot of manipulations > on 'info' - which makes the assert pointless because if > info was NULL it would have crashed earlier. > This sounds sensible. > Remove it and make it an return. Also

[Xen-devel] [PATCH 3/4] libxl/remus: Change the assert for info to an return

2016-01-26 Thread Konrad Rzeszutek Wilk
The assert(info) is after quite a lot of manipulations on 'info' - which makes the assert pointless because if info was NULL it would have crashed earlier. Remove it and make it an return. Also since most of the error paths are for the same rc, unify them. CC: Wen Congyang CC: Yang Hongyang Sig