Re: [Xen-devel] [PATCH 3/4] x86/xstate: fix fault behavior on XRSTORS

2016-01-29 Thread Jan Beulich
>>> On 29.01.16 at 17:48, wrote: > On 29/01/16 10:29, Jan Beulich wrote: >> --- a/xen/arch/x86/xstate.c >> +++ b/xen/arch/x86/xstate.c >> @@ -29,6 +29,8 @@ unsigned int *__read_mostly xstate_sizes >> static unsigned int __read_mostly xstate_features; >> static unsigned int __read_mostly >> xsta

Re: [Xen-devel] [PATCH 3/4] x86/xstate: fix fault behavior on XRSTORS

2016-01-29 Thread Andrew Cooper
On 29/01/16 10:29, Jan Beulich wrote: > XRSTORS unconditionally faults when xcomp_bv has bit 63 clear. Instead > of just fixing this issue, overhaul the fault recovery code, which - > one of the many mistakes made when xstate support got introduced - was > blindly mirroring that accompanying FXRSTO

[Xen-devel] [PATCH 3/4] x86/xstate: fix fault behavior on XRSTORS

2016-01-29 Thread Jan Beulich
XRSTORS unconditionally faults when xcomp_bv has bit 63 clear. Instead of just fixing this issue, overhaul the fault recovery code, which - one of the many mistakes made when xstate support got introduced - was blindly mirroring that accompanying FXRSTOR, neglecting the fact that XRSTOR{,S} aren't