Re: [Xen-devel] [PATCH 4/4] libxenstat: qmp_read fix and cleanup

2015-04-08 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH 4/4] libxenstat: qmp_read fix and cleanup"): > On 08/04/15 16:01, Wei Liu wrote: > > The second argument of poll(2) is the number of file descriptors. POLLIN > > is defined as 1 so it happens to work. ... > > @@ -311,6 +312,9 @@ static int qmp_read(int qfd, unsigne

Re: [Xen-devel] [PATCH 4/4] libxenstat: qmp_read fix and cleanup

2015-04-08 Thread Wei Liu
On Wed, Apr 08, 2015 at 04:25:06PM +0100, Andrew Cooper wrote: > On 08/04/15 16:01, Wei Liu wrote: > > The second argument of poll(2) is the number of file descriptors. POLLIN > > is defined as 1 so it happens to work. > > > > Also do two cleanups while I was there: > > 1. There is only one fd, so

Re: [Xen-devel] [PATCH 4/4] libxenstat: qmp_read fix and cleanup

2015-04-08 Thread Andrew Cooper
On 08/04/15 16:01, Wei Liu wrote: > The second argument of poll(2) is the number of file descriptors. POLLIN > is defined as 1 so it happens to work. > > Also do two cleanups while I was there: > 1. There is only one fd, so a one-element array is enough. > 2. Initialise pfd to make code linter happ

[Xen-devel] [PATCH 4/4] libxenstat: qmp_read fix and cleanup

2015-04-08 Thread Wei Liu
The second argument of poll(2) is the number of file descriptors. POLLIN is defined as 1 so it happens to work. Also do two cleanups while I was there: 1. There is only one fd, so a one-element array is enough. 2. Initialise pfd to make code linter happy. Signed-off-by: Wei Liu Cc: Ian Campbell