Re: [Xen-devel] [PATCH 4/4] x86/traps: honor EXT bit in error codes

2015-11-11 Thread Jan Beulich
>>> On 10.11.15 at 19:20, wrote: > On 10/11/15 17:40, Jan Beulich wrote: >> @@ -3257,7 +3262,7 @@ void do_general_protection(struct cpu_us >> * instruction. The DPL specified by the guest OS for these vectors is >> NOT >> * CHECKED!! >> */ >> -if

[Xen-devel] [PATCH 4/4] x86/traps: honor EXT bit in error codes

2015-11-10 Thread Jan Beulich
The specification does not explicitly limit the use of this bit to exceptions that can have selector style error codes, so to be on the safe side we should deal with it being set even on error codes formally documented to be always zero (if they're indeed always zero, the change is simply dead

Re: [Xen-devel] [PATCH 4/4] x86/traps: honor EXT bit in error codes

2015-11-10 Thread Andrew Cooper
On 10/11/15 17:40, Jan Beulich wrote: > The specification does not explicitly limit the use of this bit to > exceptions that can have selector style error codes, so to be on the > safe side we should deal with it being set even on error codes formally > documented to be always zero (if they're