Re: [Xen-devel] [PATCH 6/8] xen/x86: Avoid overriding initialisers in arrays

2016-02-15 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Wednesday, February 10, 2016 4:02 AM > > Clang objects to having multiple initialisers when creating an array. > > As this warning is useful for spotting obscure bugs, disabling it is > unhelpful. Instead, fix our two deliberate us

Re: [Xen-devel] [PATCH 6/8] xen/x86: Avoid overriding initialisers in arrays

2016-02-10 Thread George Dunlap
On 10/02/16 14:03, Jan Beulich wrote: On 10.02.16 at 14:50, wrote: >> On 10/02/16 13:22, Jan Beulich wrote: >> On 09.02.16 at 21:01, wrote: Clang objects to having multiple initialisers when creating an array. As this warning is useful for spotting obscure bugs, disabling

Re: [Xen-devel] [PATCH 6/8] xen/x86: Avoid overriding initialisers in arrays

2016-02-10 Thread Jan Beulich
>>> On 10.02.16 at 14:50, wrote: > On 10/02/16 13:22, Jan Beulich wrote: > On 09.02.16 at 21:01, wrote: >>> Clang objects to having multiple initialisers when creating an array. >>> >>> As this warning is useful for spotting obscure bugs, disabling it is >>> unhelpful. Instead, fix our two d

Re: [Xen-devel] [PATCH 6/8] xen/x86: Avoid overriding initialisers in arrays

2016-02-10 Thread Andrew Cooper
On 10/02/16 13:22, Jan Beulich wrote: On 09.02.16 at 21:01, wrote: >> Clang objects to having multiple initialisers when creating an array. >> >> As this warning is useful for spotting obscure bugs, disabling it is >> unhelpful. Instead, fix our two deliberate usecases. > Ugly again, but - w

Re: [Xen-devel] [PATCH 6/8] xen/x86: Avoid overriding initialisers in arrays

2016-02-10 Thread Jan Beulich
>>> On 09.02.16 at 21:01, wrote: > Clang objects to having multiple initialisers when creating an array. > > As this warning is useful for spotting obscure bugs, disabling it is > unhelpful. Instead, fix our two deliberate usecases. Ugly again, but - well ... > --- a/xen/arch/x86/mm/p2m-ept.c

Re: [Xen-devel] [PATCH 6/8] xen/x86: Avoid overriding initialisers in arrays

2016-02-10 Thread George Dunlap
On 09/02/16 20:01, Andrew Cooper wrote: > Clang objects to having multiple initialisers when creating an array. > > As this warning is useful for spotting obscure bugs, disabling it is > unhelpful. Instead, fix our two deliberate usecases. > > In the p2m-ept case, pull the array out into a helpe

[Xen-devel] [PATCH 6/8] xen/x86: Avoid overriding initialisers in arrays

2016-02-09 Thread Andrew Cooper
Clang objects to having multiple initialisers when creating an array. As this warning is useful for spotting obscure bugs, disabling it is unhelpful. Instead, fix our two deliberate usecases. In the p2m-ept case, pull the array out into a helper function, so the helper can guarentee to cover the