Re: [Xen-devel] [PATCH Altp2m cleanup 2/3 v12 1/3] Move altp2m specific functions to altp2m files.

On 10/11/16 23:45, Paul Lai wrote: > Moving altp2m domain startup and teardown into altp2m_domain_init() > and altp2m_domain_teardown() respectively. You're not "moving" the startup into a function unless the new function appears *and* the old code disappears. I think it would be better to have

Re: [Xen-devel] [PATCH Altp2m cleanup 2/3 v12 1/3] Move altp2m specific functions to altp2m files.

>>> On 11.11.16 at 00:45, wrote: > @@ -66,6 +67,60 @@ altp2m_vcpu_destroy(struct vcpu *v) > } > > /* > + * allocate and initialize memory for altp2m portion of domain > + * > + * returns < 0 on error > + * returns 0 on no operation & success > + */ > +int >

[Xen-devel] [PATCH Altp2m cleanup 2/3 v12 1/3] Move altp2m specific functions to altp2m files.

Moving altp2m domain startup and teardown into altp2m_domain_init() and altp2m_domain_teardown() respectively. Moving hvm_altp2m_supported() check into functions that use it for better readability. Got rid of stray blanks after open paren after function names. Defining _XEN_ASM_X86_P2M_H instead