Re: [Xen-devel] [PATCH QEMU-XEN v4 1/9] xen_console: correctly cleanup primary console on teardown.

2015-10-22 Thread Stefano Stabellini
On Wed, 21 Oct 2015, Ian Campbell wrote: > All of the work in con_disconnect applies to the primary console case > (when xendev->dev is NULL). Therefore remove the early check and bail > and allow it to fall through. All of the existing code is correctly > conditional already. > > The ->dev and

[Xen-devel] [PATCH QEMU-XEN v4 1/9] xen_console: correctly cleanup primary console on teardown.

2015-10-21 Thread Ian Campbell
All of the work in con_disconnect applies to the primary console case (when xendev->dev is NULL). Therefore remove the early check and bail and allow it to fall through. All of the existing code is correctly conditional already. The ->dev and ->gnttabdev handles are either both set or neither.