Re: [Xen-devel] [PATCH RFC 04/13] x86/mm: carve out create_grant_pv_mapping

2017-04-03 Thread Andrew Cooper
On 03/04/17 09:40, Wei Liu wrote: > On Wed, Mar 29, 2017 at 11:27:49AM +0100, Andrew Cooper wrote: >> On 27/03/17 10:10, Wei Liu wrote: >>> We will later split out PV specific code to pv/mm.c. >>> >>> No functional change. >>> >>> Signed-off-by: Wei Liu >> Please could you take the time to correct

Re: [Xen-devel] [PATCH RFC 04/13] x86/mm: carve out create_grant_pv_mapping

2017-04-03 Thread Wei Liu
On Wed, Mar 29, 2017 at 11:27:49AM +0100, Andrew Cooper wrote: > On 27/03/17 10:10, Wei Liu wrote: > > We will later split out PV specific code to pv/mm.c. > > > > No functional change. > > > > Signed-off-by: Wei Liu > > Please could you take the time to correctly mfn_t/gfn_t the calls. > Having

Re: [Xen-devel] [PATCH RFC 04/13] x86/mm: carve out create_grant_pv_mapping

2017-03-29 Thread Wei Liu
On Wed, Mar 29, 2017 at 11:49:54AM +0100, Andrew Cooper wrote: > On 29/03/17 11:45, Jan Beulich wrote: > On 29.03.17 at 12:27, wrote: > >> One idea I had while starting the hypercall work was to introduce a > >> "struct guest_type_ops" to contain some function pointers for options we > >> per

Re: [Xen-devel] [PATCH RFC 04/13] x86/mm: carve out create_grant_pv_mapping

2017-03-29 Thread Andrew Cooper
On 29/03/17 11:45, Jan Beulich wrote: On 29.03.17 at 12:27, wrote: >> One idea I had while starting the hypercall work was to introduce a >> "struct guest_type_ops" to contain some function pointers for options we >> perform on all guests, irrespective of type. My first candidate for >> spli

Re: [Xen-devel] [PATCH RFC 04/13] x86/mm: carve out create_grant_pv_mapping

2017-03-29 Thread Jan Beulich
>>> On 29.03.17 at 12:27, wrote: > One idea I had while starting the hypercall work was to introduce a > "struct guest_type_ops" to contain some function pointers for options we > perform on all guests, irrespective of type. My first candidate for > splitting this way was the hypercall page writi

Re: [Xen-devel] [PATCH RFC 04/13] x86/mm: carve out create_grant_pv_mapping

2017-03-29 Thread Andrew Cooper
On 27/03/17 10:10, Wei Liu wrote: > We will later split out PV specific code to pv/mm.c. > > No functional change. > > Signed-off-by: Wei Liu Please could you take the time to correctly mfn_t/gfn_t the calls. Having both addr and frame, and them being otherwise unqualified, is confusing to read.

[Xen-devel] [PATCH RFC 04/13] x86/mm: carve out create_grant_pv_mapping

2017-03-27 Thread Wei Liu
We will later split out PV specific code to pv/mm.c. No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/mm.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 4bf94227cc..b44d44c782 100644 --- a/xen/arch/