Re: [Xen-devel] [PATCH RFC 2/8] golang/xenlight: Add error constants and standard handling

2017-01-27 Thread George Dunlap
On 23/01/17 16:43, Ronald Rojas wrote: > Create error type Errorxl for throwing proper xenlight > errors. > > Update Ctx functions to throw Errorxl errors. > > Signed-off-by: Ronald Rojas Everything here looks, good with a few nitpicks... > --- >

[Xen-devel] [PATCH RFC 2/8] golang/xenlight: Add error constants and standard handling

2017-01-23 Thread Ronald Rojas
Create error type Errorxl for throwing proper xenlight errors. Update Ctx functions to throw Errorxl errors. Signed-off-by: Ronald Rojas --- tools/golang/xenlight/xenlight.go | 75 ++- 1 file changed, 74 insertions(+), 1 deletion(-)

Re: [Xen-devel] [PATCH RFC 2/8] golang/xenlight: Add error constants and standard handling

2017-01-19 Thread George Dunlap
On 18/01/17 19:56, Ronald Rojas wrote: > Create error type Errorxl for throwing proper xenlight > errors. > > Update Ctx functions to throw Errorxl errors. > > Signed-off-by: Ronald Rojas Overall, looks good! Thanks for this. Just a few minor comments. > --- >

Re: [Xen-devel] [PATCH RFC 2/8] golang/xenlight: Add error constants and standard handling

2017-01-19 Thread Dario Faggioli
On Thu, 2017-01-19 at 16:02 +, George Dunlap wrote: > On 19/01/17 15:13, Ronald Rojas wrote: > > It's possible to add the errors as part of the first patch and then > > add the context functions as the second patch as Go will at least  > > let you compile the errors on it's own. I can swap the

Re: [Xen-devel] [PATCH RFC 2/8] golang/xenlight: Add error constants and standard handling

2017-01-19 Thread Wei Liu
On Thu, Jan 19, 2017 at 04:02:46PM +, George Dunlap wrote: > On 19/01/17 15:13, Ronald Rojas wrote: > > On Wed, Jan 18, 2017 at 11:16:31PM +0100, Dario Faggioli wrote: > >> On Wed, 2017-01-18 at 14:56 -0500, Ronald Rojas wrote: > >>> Create error type Errorxl for throwing proper xenlight > >>>

Re: [Xen-devel] [PATCH RFC 2/8] golang/xenlight: Add error constants and standard handling

2017-01-19 Thread George Dunlap
On 19/01/17 15:13, Ronald Rojas wrote: > On Wed, Jan 18, 2017 at 11:16:31PM +0100, Dario Faggioli wrote: >> On Wed, 2017-01-18 at 14:56 -0500, Ronald Rojas wrote: >>> Create error type Errorxl for throwing proper xenlight >>> errors. >>> >>> Update Ctx functions to throw Errorxl errors. >>> >>>

Re: [Xen-devel] [PATCH RFC 2/8] golang/xenlight: Add error constants and standard handling

2017-01-19 Thread Ronald Rojas
On Wed, Jan 18, 2017 at 11:16:31PM +0100, Dario Faggioli wrote: > On Wed, 2017-01-18 at 14:56 -0500, Ronald Rojas wrote: > > Create error type Errorxl for throwing proper xenlight > > errors. > > > > Update Ctx functions to throw Errorxl errors. > > > > Signed-off-by: Ronald Rojas

Re: [Xen-devel] [PATCH RFC 2/8] golang/xenlight: Add error constants and standard handling

2017-01-18 Thread Dario Faggioli
On Wed, 2017-01-18 at 14:56 -0500, Ronald Rojas wrote: > Create error type Errorxl for throwing proper xenlight > errors. > > Update Ctx functions to throw Errorxl errors. > > Signed-off-by: Ronald Rojas > --- >  tools/golang/xenlight/xenlight.go | 77 >

[Xen-devel] [PATCH RFC 2/8] golang/xenlight: Add error constants and standard handling

2017-01-18 Thread Ronald Rojas
Create error type Errorxl for throwing proper xenlight errors. Update Ctx functions to throw Errorxl errors. Signed-off-by: Ronald Rojas --- tools/golang/xenlight/xenlight.go | 77 +-- 1 file changed, 73 insertions(+), 4 deletions(-)