Re: [Xen-devel] [PATCH V13 4/7] xen/arm: Data abort exception (R/W) mem_events.

2015-03-12 Thread Ian Campbell
On Fri, 2015-03-06 at 22:24 +0100, Tamas K Lengyel wrote: This patch enables to store, set, check and deliver LPAE R/W mem_events. As the LPAE PTE's lack enough available software programmable bits, we store the permissions in a Radix tree. The tree is only looked at if mem_access_enabled is

Re: [Xen-devel] [PATCH V13 4/7] xen/arm: Data abort exception (R/W) mem_events.

2015-03-12 Thread Ian Campbell
On Thu, 2015-03-12 at 16:13 +0100, Tamas K Lengyel wrote: and this function is nearly identical to the x86 one too. Nearly, but not completely. IMHO consolidation may be possible on some of these bits, but I'm not sure if it would make it any easier to follow when the code jumps back

Re: [Xen-devel] [PATCH V13 4/7] xen/arm: Data abort exception (R/W) mem_events.

2015-03-12 Thread Julien Grall
On 12/03/15 15:26, Tamas K Lengyel wrote: On Thu, Mar 12, 2015 at 4:13 PM, Julien Grall julien.gr...@linaro.org mailto:julien.gr...@linaro.org wrote: Hi Tamas, On 06/03/15 21:24, Tamas K Lengyel wrote: +/* + * Preempt setting mem_access permissions

Re: [Xen-devel] [PATCH V13 4/7] xen/arm: Data abort exception (R/W) mem_events.

2015-03-12 Thread Julien Grall
On 12/03/15 15:19, Tamas K Lengyel wrote: out: +if ( flush ) +{ +flush_tlb_domain(d); +iommu_iotlb_flush(d, sgfn, egfn - sgfn); +} Is moving the flush out of the loop an independent bug fix? If

Re: [Xen-devel] [PATCH V13 4/7] xen/arm: Data abort exception (R/W) mem_events.

2015-03-12 Thread Ian Campbell
On Thu, 2015-03-12 at 16:19 +0100, Tamas K Lengyel wrote: out: +if ( flush ) +{ +flush_tlb_domain(d); +iommu_iotlb_flush(d, sgfn, egfn - sgfn); +}

Re: [Xen-devel] [PATCH V13 4/7] xen/arm: Data abort exception (R/W) mem_events.

2015-03-12 Thread Julien Grall
Hi Ian, On 12/03/15 15:35, Ian Campbell wrote: On Thu, 2015-03-12 at 16:19 +0100, Tamas K Lengyel wrote: out: +if ( flush ) +{ +flush_tlb_domain(d); +iommu_iotlb_flush(d, sgfn, egfn - sgfn);

Re: [Xen-devel] [PATCH V13 4/7] xen/arm: Data abort exception (R/W) mem_events.

2015-03-12 Thread Tamas K Lengyel
On Thu, Mar 12, 2015 at 4:13 PM, Julien Grall julien.gr...@linaro.org wrote: Hi Tamas, On 06/03/15 21:24, Tamas K Lengyel wrote: +/* + * Preempt setting mem_access permissions as required by XSA-89, + * if it's not the last iteration. + */ +if

Re: [Xen-devel] [PATCH V13 4/7] xen/arm: Data abort exception (R/W) mem_events.

2015-03-12 Thread Tamas K Lengyel
On Thu, Mar 12, 2015 at 2:35 PM, Ian Campbell ian.campb...@citrix.com wrote: On Fri, 2015-03-06 at 22:24 +0100, Tamas K Lengyel wrote: This patch enables to store, set, check and deliver LPAE R/W mem_events. As the LPAE PTE's lack enough available software programmable bits, we store the

Re: [Xen-devel] [PATCH V13 4/7] xen/arm: Data abort exception (R/W) mem_events.

2015-03-12 Thread Tamas K Lengyel
out: +if ( flush ) +{ +flush_tlb_domain(d); +iommu_iotlb_flush(d, sgfn, egfn - sgfn); +} Is moving the flush out of the loop an independent bug fix? If so please do in a separate commit with a rationale in the commit log. If it is somehow related to the

Re: [Xen-devel] [PATCH V13 4/7] xen/arm: Data abort exception (R/W) mem_events.

2015-03-12 Thread Ian Campbell
On Thu, 2015-03-12 at 15:37 +, Julien Grall wrote: On 12/03/15 15:26, Tamas K Lengyel wrote: On Thu, Mar 12, 2015 at 4:13 PM, Julien Grall julien.gr...@linaro.org mailto:julien.gr...@linaro.org wrote: Hi Tamas, On 06/03/15 21:24, Tamas K Lengyel wrote: +

Re: [Xen-devel] [PATCH V13 4/7] xen/arm: Data abort exception (R/W) mem_events.

2015-03-12 Thread Julien Grall
On 12/03/15 15:46, Ian Campbell wrote: On Thu, 2015-03-12 at 15:37 +, Julien Grall wrote: On 12/03/15 15:26, Tamas K Lengyel wrote: On Thu, Mar 12, 2015 at 4:13 PM, Julien Grall julien.gr...@linaro.org mailto:julien.gr...@linaro.org wrote: Hi Tamas, On 06/03/15 21:24, Tamas K

Re: [Xen-devel] [PATCH V13 4/7] xen/arm: Data abort exception (R/W) mem_events.

2015-03-12 Thread Julien Grall
Hi Tamas, On 06/03/15 21:24, Tamas K Lengyel wrote: +/* + * Preempt setting mem_access permissions as required by XSA-89, + * if it's not the last iteration. + */ +if ( op == MEMACCESS count ) +{ +uint32_t progress =