Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

2016-02-19 Thread Olaf Hering
On Fri, Feb 19, Olaf Hering wrote: > Not sure how to handle it, perhaps exit when xl -N is called? Also the interface is 'xl -N' is not clearly defined. What is it supposed to do with the newly introduced ctrl types? Should it display the json just for the dev, just for the ctrl+dev or the

Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

2016-02-19 Thread Olaf Hering
On Fri, Feb 19, Chun Yan Liu wrote: > > > >>> On 2/17/2016 at 12:56 AM, in message <20160216165608.ga21...@gmail.com>, > >>> Olaf > Hering wrote: > > On Tue, Jan 19, Chunyan Liu wrote: > > > > > #xl usbctrl-attach test_vm version=1 ports=8 > > > > > #xl usbdev-attach

Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

2016-02-19 Thread Chun Yan Liu
>>> On 2/17/2016 at 12:56 AM, in message <20160216165608.ga21...@gmail.com>, >>> Olaf Hering wrote: > On Tue, Jan 19, Chunyan Liu wrote: > > > #xl usbctrl-attach test_vm version=1 ports=8 > > > #xl usbdev-attach test_vm hostbus=1 hostaddr=2 > > I think this does not

Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

2016-02-17 Thread Ian Jackson
Wei Liu writes ("Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands"): > On Tue, Feb 16, 2016 at 05:53:18PM +, Ian Jackson wrote: > > I don't have a strong opinion, but I would lean towards insisting that > > on command lines each setting should be in its own

Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

2016-02-17 Thread Wei Liu
On Tue, Feb 16, 2016 at 05:53:18PM +, Ian Jackson wrote: > Jim Fehlig writes ("Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands"): > > I just noticed this is the case with network devices as well. E.g. > > > > #xl network-attach hvm-domU mac=00:16:3e:xx:yy

Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

2016-02-16 Thread Chun Yan Liu
n >>> On 2/17/2016 at 12:56 AM, in message <20160216165608.ga21...@gmail.com>, >>> Olaf Hering wrote: > On Tue, Jan 19, Chunyan Liu wrote: > > > #xl usbctrl-attach test_vm version=1 ports=8 > > > #xl usbdev-attach test_vm hostbus=1 hostaddr=2 > > I think this does

Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

2016-02-16 Thread Ian Jackson
Jim Fehlig writes ("Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands"): > I just noticed this is the case with network devices as well. E.g. > > #xl network-attach hvm-domU mac=00:16:3e:xx:yy:zz,bridge=br0 > libxl: error: libxl_device.c:1095:device_hotplug_child_d

Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

2016-02-16 Thread Olaf Hering
On Tue, Jan 19, Chunyan Liu wrote: > #xl usbctrl-attach test_vm version=1 ports=8 > #xl usbdev-attach test_vm hostbus=1 hostaddr=2 I think this does not handle the -N knob of xl. Other commands check the global dryrun_only variable. Olaf ___

Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

2016-01-21 Thread Ian Campbell
On Thu, 2016-01-21 at 12:12 +, Wei Liu wrote: > On Tue, Jan 19, 2016 at 08:10:07PM -0700, Jim Fehlig wrote: > > On 01/19/2016 11:11 AM, Ian Jackson wrote: > > > Chunyan Liu writes ("[PATCH V13 5/5] xl: add pvusb commands"): > > > > Add pvusb commands: usbctrl-attach, usbctrl-detach, usb-list,

Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

2016-01-21 Thread Wei Liu
On Tue, Jan 19, 2016 at 08:10:07PM -0700, Jim Fehlig wrote: > On 01/19/2016 11:11 AM, Ian Jackson wrote: > > Chunyan Liu writes ("[PATCH V13 5/5] xl: add pvusb commands"): > >> Add pvusb commands: usbctrl-attach, usbctrl-detach, usb-list, > >> usbdev-attach and usbdev-detach. > > Thanks for

Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

2016-01-21 Thread Wei Liu
On Thu, Jan 21, 2016 at 12:21:11PM +, Ian Campbell wrote: > On Thu, 2016-01-21 at 12:12 +, Wei Liu wrote: > > On Tue, Jan 19, 2016 at 08:10:07PM -0700, Jim Fehlig wrote: > > > On 01/19/2016 11:11 AM, Ian Jackson wrote: > > > > Chunyan Liu writes ("[PATCH V13 5/5] xl: add pvusb commands"):

Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

2016-01-21 Thread Ian Jackson
Wei Liu writes ("Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands"): > Or rewrite every adhoc parser with bison/flex or Ocaml / Haskell parsec. I endorse this product and/or service. > Jokes aside. I will see what I can do. Consolidating them into helper > functions is

[Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

2016-01-19 Thread Chunyan Liu
Add pvusb commands: usbctrl-attach, usbctrl-detach, usb-list, usbdev-attach and usbdev-detach. To attach a usb device to guest through pvusb, one could follow following example: #xl usbctrl-attach test_vm version=1 ports=8 #xl usb-list test_vm will show the usb controllers and port usage

Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

2016-01-19 Thread Ian Jackson
Chunyan Liu writes ("[PATCH V13 5/5] xl: add pvusb commands"): > Add pvusb commands: usbctrl-attach, usbctrl-detach, usb-list, > usbdev-attach and usbdev-detach. Thanks for swapping this with the other patch. It is better now. > +=item B I I However, I think you need to explictly state that

Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

2016-01-19 Thread Jim Fehlig
On 01/19/2016 11:11 AM, Ian Jackson wrote: > Chunyan Liu writes ("[PATCH V13 5/5] xl: add pvusb commands"): >> Add pvusb commands: usbctrl-attach, usbctrl-detach, usb-list, >> usbdev-attach and usbdev-detach. > Thanks for swapping this with the other patch. It is better now. > >> +=item B I I >