Re: [Xen-devel] [PATCH V2] Decouple SnadyBridge quirk form VTd timeout

2014-11-17 Thread Dugger, Donald D
Hmm, good ideas. How about I change the `snb_igd_quirk' parameter to be: snb_igd_quirk = current behavior, enable quirk with 1 sec timeout snb_igd_quirk=default = enable quirk with theoretical max timeout of 670 msec

Re: [Xen-devel] [PATCH V2] Decouple SnadyBridge quirk form VTd timeout

2014-11-17 Thread Jan Beulich
On 17.11.14 at 14:32, donald.d.dug...@intel.com wrote: Hmm, good ideas. How about I change the `snb_igd_quirk' parameter to be: snb_igd_quirk = current behavior, enable quirk with 1 sec timeout snb_igd_quirk=default = enable quirk with

Re: [Xen-devel] [PATCH V2] Decouple SnadyBridge quirk form VTd timeout

2014-11-17 Thread Dugger, Donald D
I'm a big believer in backward compatibility, especially in not doing things that change current defined behavior. The current `snb_igd_quirk' flag enables the quirk code with a 1sec timeout. Even though that value is excessive silently changing the meaning of the parameter just seems wrong.

Re: [Xen-devel] [PATCH V2] Decouple SnadyBridge quirk form VTd timeout

2014-11-17 Thread Jan Beulich
On 17.11.14 at 15:51, donald.d.dug...@intel.com wrote: My primary goal is to decouple the IGD quirk code from the VTd timeout value, the two are unrelated and shouldn't be using the same define. In the process we can clean up the IGD code so that, if a user wants, the user can specify a

[Xen-devel] [PATCH V2] Decouple SnadyBridge quirk form VTd timeout

2014-11-16 Thread Don Dugger
Currently the quirk code for SandyBridge uses the VTd timeout value when writing to an IGD register. This is the wrong timeout to use and, at 1000 msec, is much too large. Change this behavior by adding a new boot paramter, snb_igd_timeout, that can specify the timeout to be used when accessing