Re: [Xen-devel] [PATCH V2] common/mem_access: merged mem_access setting interfaces

2017-03-21 Thread Jan Beulich
>>> On 20.03.17 at 21:20, wrote: > On 03/20/2017 06:54 PM, Jan Beulich wrote: > On 20.03.17 at 17:48, wrote: >>> On 03/20/2017 06:40 PM, Jan Beulich wrote: >>> On 20.03.17 at 17:16, wrote: > On

Re: [Xen-devel] [PATCH V2] common/mem_access: merged mem_access setting interfaces

2017-03-20 Thread Tamas K Lengyel
On Mon, Mar 20, 2017 at 2:20 PM, Razvan Cojocaru wrote: > On 03/20/2017 06:54 PM, Jan Beulich wrote: > On 20.03.17 at 17:48, wrote: > >> On 03/20/2017 06:40 PM, Jan Beulich wrote: > >> On 20.03.17 at 17:16,

Re: [Xen-devel] [PATCH V2] common/mem_access: merged mem_access setting interfaces

2017-03-20 Thread Razvan Cojocaru
On 03/20/2017 06:54 PM, Jan Beulich wrote: On 20.03.17 at 17:48, wrote: >> On 03/20/2017 06:40 PM, Jan Beulich wrote: >> On 20.03.17 at 17:16, wrote: On 03/20/2017 06:14 PM, Razvan Cojocaru wrote: > In any case, back when

Re: [Xen-devel] [PATCH V2] common/mem_access: merged mem_access setting interfaces

2017-03-20 Thread Jan Beulich
>>> On 20.03.17 at 17:48, wrote: > On 03/20/2017 06:40 PM, Jan Beulich wrote: > On 20.03.17 at 17:16, wrote: >>> On 03/20/2017 06:14 PM, Razvan Cojocaru wrote: In any case, back when I've added xc_set_mem_access_multi() I've also

Re: [Xen-devel] [PATCH V2] common/mem_access: merged mem_access setting interfaces

2017-03-20 Thread Razvan Cojocaru
On 03/20/2017 06:40 PM, Jan Beulich wrote: On 20.03.17 at 17:16, wrote: >> On 03/20/2017 06:14 PM, Razvan Cojocaru wrote: >>> On 03/20/2017 06:07 PM, Jan Beulich wrote: >>> On 20.03.17 at 10:50, wrote: > ---

Re: [Xen-devel] [PATCH V2] common/mem_access: merged mem_access setting interfaces

2017-03-20 Thread Jan Beulich
>>> On 20.03.17 at 17:16, wrote: > On 03/20/2017 06:14 PM, Razvan Cojocaru wrote: >> On 03/20/2017 06:07 PM, Jan Beulich wrote: >> On 20.03.17 at 10:50, wrote: --- a/xen/include/public/memory.h +++ b/xen/include/public/memory.h

Re: [Xen-devel] [PATCH V2] common/mem_access: merged mem_access setting interfaces

2017-03-20 Thread Tamas K Lengyel
On Mon, Mar 20, 2017 at 8:20 AM, Andrew Cooper wrote: > On 20/03/17 09:50, Razvan Cojocaru wrote: > > xc_altp2m_set_mem_access() and xc_set_mem_access() end up doing the same > thing > > in the hypervisor, but the former is a HVMOP and the latter a DOMCTL. > Since > >

Re: [Xen-devel] [PATCH V2] common/mem_access: merged mem_access setting interfaces

2017-03-20 Thread Razvan Cojocaru
On 03/20/2017 06:14 PM, Razvan Cojocaru wrote: > On 03/20/2017 06:07 PM, Jan Beulich wrote: > On 20.03.17 at 10:50, wrote: >>> --- a/xen/include/public/memory.h >>> +++ b/xen/include/public/memory.h >>> @@ -444,6 +444,8 @@ struct xen_mem_access_op { >>> /*

Re: [Xen-devel] [PATCH V2] common/mem_access: merged mem_access setting interfaces

2017-03-20 Thread Razvan Cojocaru
On 03/20/2017 06:07 PM, Jan Beulich wrote: On 20.03.17 at 10:50, wrote: >> --- a/xen/include/public/memory.h >> +++ b/xen/include/public/memory.h >> @@ -444,6 +444,8 @@ struct xen_mem_access_op { >> /* xenmem_access_t */ >> uint8_t access; >> domid_t

Re: [Xen-devel] [PATCH V2] common/mem_access: merged mem_access setting interfaces

2017-03-20 Thread Jan Beulich
>>> On 20.03.17 at 10:50, wrote: > --- a/xen/include/public/memory.h > +++ b/xen/include/public/memory.h > @@ -444,6 +444,8 @@ struct xen_mem_access_op { > /* xenmem_access_t */ > uint8_t access; > domid_t domid; > +uint16_t view_id; > +uint16_t

Re: [Xen-devel] [PATCH V2] common/mem_access: merged mem_access setting interfaces

2017-03-20 Thread Razvan Cojocaru
On 03/20/2017 04:20 PM, Andrew Cooper wrote: > On 20/03/17 09:50, Razvan Cojocaru wrote: >> xc_altp2m_set_mem_access() and xc_set_mem_access() end up doing the same >> thing >> in the hypervisor, but the former is a HVMOP and the latter a DOMCTL. Since >> nobody is currently using, or has stated

Re: [Xen-devel] [PATCH V2] common/mem_access: merged mem_access setting interfaces

2017-03-20 Thread Razvan Cojocaru
On 03/20/2017 04:20 PM, Andrew Cooper wrote: > On 20/03/17 09:50, Razvan Cojocaru wrote: >> xc_altp2m_set_mem_access() and xc_set_mem_access() end up doing the same >> thing >> in the hypervisor, but the former is a HVMOP and the latter a DOMCTL. Since >> nobody is currently using, or has stated

Re: [Xen-devel] [PATCH V2] common/mem_access: merged mem_access setting interfaces

2017-03-20 Thread Andrew Cooper
On 20/03/17 09:50, Razvan Cojocaru wrote: > xc_altp2m_set_mem_access() and xc_set_mem_access() end up doing the same thing > in the hypervisor, but the former is a HVMOP and the latter a DOMCTL. Since > nobody is currently using, or has stated intent to use, this functionality > specifically as an

[Xen-devel] [PATCH V2] common/mem_access: merged mem_access setting interfaces

2017-03-20 Thread Razvan Cojocaru
xc_altp2m_set_mem_access() and xc_set_mem_access() end up doing the same thing in the hypervisor, but the former is a HVMOP and the latter a DOMCTL. Since nobody is currently using, or has stated intent to use, this functionality specifically as an HVMOP, this patch removes the HVMOP while adding