Re: [Xen-devel] [PATCH XEN v2] x86/pt: add a MSI unmask flag to XEN_DOMCTL_bind_pt_irq

2017-08-24 Thread Roger Pau Monne
On Thu, Aug 24, 2017 at 07:04:55AM -0600, Jan Beulich wrote: > >>> On 24.08.17 at 14:19, wrote: > > @@ -438,6 +439,20 @@ int pt_irq_create_bind( > > pi_update_irte(vcpu ? >arch.hvm_vmx.pi_desc : NULL, > > info, pirq_dpci->gmsi.gvec);

Re: [Xen-devel] [PATCH XEN v2] x86/pt: add a MSI unmask flag to XEN_DOMCTL_bind_pt_irq

2017-08-24 Thread Jan Beulich
>>> On 24.08.17 at 14:19, wrote: > @@ -438,6 +439,20 @@ int pt_irq_create_bind( > pi_update_irte(vcpu ? >arch.hvm_vmx.pi_desc : NULL, > info, pirq_dpci->gmsi.gvec); > > +if ( pt_irq_bind->u.msi.gflags & VMSI_UNMASKED ) > +

[Xen-devel] [PATCH XEN v2] x86/pt: add a MSI unmask flag to XEN_DOMCTL_bind_pt_irq

2017-08-24 Thread Roger Pau Monne
The flag is part of the gflags, and should be used to request the unmask of a MSI interrupt once it's bound. This is required for the device model in order to be capable of binding MSIX interrupts that have the entry mask bit already unset at bind time. Without this fix the interrupts would be