Re: [Xen-devel] [PATCH XEN v5 09/23] tools: Refactor hypercall calling wrappers into libxencall.

2015-12-02 Thread Ian Campbell
On Fri, 2015-11-13 at 15:49 +, Andrew Cooper wrote: > On 09/11/15 12:00, Ian Campbell wrote: > > diff --git a/tools/libs/call/linux.c b/tools/libs/call/linux.c > > new file mode 100644 > > index 000..906ca7e > > --- /dev/null > > +++ b/tools/libs/call/linux.c > > @@ -0,0 +1,132 @@ > > +/*

Re: [Xen-devel] [PATCH XEN v5 09/23] tools: Refactor hypercall calling wrappers into libxencall.

2015-11-13 Thread Andrew Cooper
On 09/11/15 12:00, Ian Campbell wrote: > diff --git a/tools/libs/call/include/xencall.h > b/tools/libs/call/include/xencall.h > new file mode 100644 > index 000..a0b3591 > --- /dev/null > +++ b/tools/libs/call/include/xencall.h > @@ -0,0 +1,84 @@ > +/* > + * This library is free software; you

Re: [Xen-devel] [PATCH XEN v5 09/23] tools: Refactor hypercall calling wrappers into libxencall.

2015-11-13 Thread Roger Pau Monné
El 13/11/15 a les 17.57, Ian Campbell ha escrit: > On Fri, 2015-11-13 at 15:16 +, Ian Campbell wrote: >> >> On FreeBSD hypercall->retval is in the XEN_ERRNO_* space. But I think we >> probably want to map onto the FreeBSD ERRNO space, IIRC we decided on this >> approach, rather than converting

Re: [Xen-devel] [PATCH XEN v5 09/23] tools: Refactor hypercall calling wrappers into libxencall.

2015-11-13 Thread Andrew Cooper
On 09/11/15 12:00, Ian Campbell wrote: > diff --git a/tools/libs/call/linux.c b/tools/libs/call/linux.c > new file mode 100644 > index 000..906ca7e > --- /dev/null > +++ b/tools/libs/call/linux.c > @@ -0,0 +1,132 @@ > +/* > + * This library is free software; you can redistribute it and/or > +

Re: [Xen-devel] [PATCH XEN v5 09/23] tools: Refactor hypercall calling wrappers into libxencall.

2015-11-13 Thread Ian Campbell
On Fri, 2015-11-13 at 18:16 +0100, Roger Pau Monné wrote: > El 13/11/15 a les 17.57, Ian Campbell ha escrit: > > On Fri, 2015-11-13 at 15:16 +, Ian Campbell wrote: > > > > > > On FreeBSD hypercall->retval is in the XEN_ERRNO_* space. But I think > > > we > > > probably want to map onto the

Re: [Xen-devel] [PATCH XEN v5 09/23] tools: Refactor hypercall calling wrappers into libxencall.

2015-11-13 Thread Ian Campbell
On Wed, 2015-11-11 at 15:31 +, Wei Liu wrote: > On Wed, Nov 11, 2015 at 03:08:13PM +, Ian Jackson wrote: > > Ian Campbell writes ("[PATCH XEN v5 09/23] tools: Refactor hypercall > > calling wrappers into libxencall."): > > > libxencall will provide a stable API and ABI for calling

Re: [Xen-devel] [PATCH XEN v5 09/23] tools: Refactor hypercall calling wrappers into libxencall.

2015-11-13 Thread Ian Campbell
On Wed, 2015-11-11 at 15:08 +, Ian Jackson wrote: > Ian Campbell writes ("[PATCH XEN v5 09/23] tools: Refactor hypercall > calling wrappers into libxencall."): > > libxencall will provide a stable API and ABI for calling hypercalls > > (although those hypercalls themselves may not have a

Re: [Xen-devel] [PATCH XEN v5 09/23] tools: Refactor hypercall calling wrappers into libxencall.

2015-11-13 Thread Ian Campbell
On Fri, 2015-11-13 at 15:16 +, Ian Campbell wrote: >  > If we are going to standardise on one of those then given we've gone for > -1/errno in most other places and it's the "normal" way to do things I > think we should do the same here and the freebsd driver in libxencall > should set errno.

Re: [Xen-devel] [PATCH XEN v5 09/23] tools: Refactor hypercall calling wrappers into libxencall.

2015-11-13 Thread Ian Campbell
On Fri, 2015-11-13 at 15:16 +, Ian Campbell wrote: > > On FreeBSD hypercall->retval is in the XEN_ERRNO_* space. But I think we > probably want to map onto the FreeBSD ERRNO space, IIRC we decided on this > approach, rather than converting all our callers to the XEN_ERRNO_* space, > in a

Re: [Xen-devel] [PATCH XEN v5 09/23] tools: Refactor hypercall calling wrappers into libxencall.

2015-11-11 Thread Wei Liu
On Wed, Nov 11, 2015 at 03:08:13PM +, Ian Jackson wrote: > Ian Campbell writes ("[PATCH XEN v5 09/23] tools: Refactor hypercall calling > wrappers into libxencall."): > > libxencall will provide a stable API and ABI for calling hypercalls > > (although those hypercalls themselves may not have

Re: [Xen-devel] [PATCH XEN v5 09/23] tools: Refactor hypercall calling wrappers into libxencall.

2015-11-11 Thread Ian Jackson
Ian Campbell writes ("[PATCH XEN v5 09/23] tools: Refactor hypercall calling wrappers into libxencall."): > libxencall will provide a stable API and ABI for calling hypercalls > (although those hypercalls themselves may not have a stable API). As > well as the hypercall buffer infrastructure

[Xen-devel] [PATCH XEN v5 09/23] tools: Refactor hypercall calling wrappers into libxencall.

2015-11-09 Thread Ian Campbell
libxencall will provide a stable API and ABI for calling hypercalls (although those hypercalls themselves may not have a stable API). As well as the hypercall buffer infrastructure needed in order to safely provide pointer arguments to hypercalls. libxenctrl encapsulates a instance of this