Re: [Xen-devel] [PATCH for-4.10] common/spinlock: Improve the output from check_lock() if it trips

2017-11-13 Thread Julien Grall
Hi Jan, On 11/06/2017 11:09 AM, Jan Beulich wrote: On 31.10.17 at 11:49, wrote: --- a/xen/common/spinlock.c +++ b/xen/common/spinlock.c @@ -44,7 +44,13 @@ static void check_lock(struct lock_debug *debug) if ( unlikely(debug->irq_safe != irq_safe) ) {

Re: [Xen-devel] [PATCH for-4.10] common/spinlock: Improve the output from check_lock() if it trips

2017-11-06 Thread Jan Beulich
>>> On 31.10.17 at 11:49, wrote: > --- a/xen/common/spinlock.c > +++ b/xen/common/spinlock.c > @@ -44,7 +44,13 @@ static void check_lock(struct lock_debug *debug) > if ( unlikely(debug->irq_safe != irq_safe) ) > { > int seen = cmpxchg(>irq_safe, -1,

Re: [Xen-devel] [PATCH for-4.10] common/spinlock: Improve the output from check_lock() if it trips

2017-11-02 Thread Julien Grall
Hi Andrew, On 31/10/17 10:49, Andrew Cooper wrote: If check_lock() triggers, a crash will occur. Instead of simply identifying "the irq context was different", indicate the expected and current irq context. Signed-off-by: Andrew Cooper Release-acked-by: Julien

Re: [Xen-devel] [PATCH for-4.10] common/spinlock: Improve the output from check_lock() if it trips

2017-10-31 Thread George Dunlap
On 10/31/2017 10:49 AM, Andrew Cooper wrote: > If check_lock() triggers, a crash will occur. Instead of simply identifying > "the irq context was different", indicate the expected and current irq > context. > > Signed-off-by: Andrew Cooper Reviewed-by: George Dunlap

Re: [Xen-devel] [PATCH for-4.10] common/spinlock: Improve the output from check_lock() if it trips

2017-10-31 Thread Wei Liu
On Tue, Oct 31, 2017 at 10:49:10AM +, Andrew Cooper wrote: > If check_lock() triggers, a crash will occur. Instead of simply identifying > "the irq context was different", indicate the expected and current irq > context. > > Signed-off-by: Andrew Cooper

[Xen-devel] [PATCH for-4.10] common/spinlock: Improve the output from check_lock() if it trips

2017-10-31 Thread Andrew Cooper
If check_lock() triggers, a crash will occur. Instead of simply identifying "the irq context was different", indicate the expected and current irq context. Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Jan Beulich