Re: [Xen-devel] [PATCH for-4.10] libxl: annotate s to be nonnull in libxl__enum_from_string

2017-10-23 Thread Wei Liu
On Mon, Oct 23, 2017 at 02:04:58PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [Xen-devel] [PATCH for-4.10] libxl: annotate s to be > nonnull in libxl__enum_from_string"): > > On Mon, Oct 23, 2017 at 01:32:50PM +0100, Julien Grall wrote: > > > I would be ok with that. Wei do you have any

Re: [Xen-devel] [PATCH for-4.10] libxl: annotate s to be nonnull in libxl__enum_from_string

2017-10-23 Thread Ian Jackson
Wei Liu writes ("Re: [Xen-devel] [PATCH for-4.10] libxl: annotate s to be nonnull in libxl__enum_from_string"): > On Mon, Oct 23, 2017 at 01:32:50PM +0100, Julien Grall wrote: > > I would be ok with that. Wei do you have any opinion? > > Sure this is a simple enough patch. We should preferably

Re: [Xen-devel] [PATCH for-4.10] libxl: annotate s to be nonnull in libxl__enum_from_string

2017-10-23 Thread Wei Liu
On Mon, Oct 23, 2017 at 01:32:50PM +0100, Julien Grall wrote: > Hi, > > On 20/10/17 11:47, Ian Jackson wrote: > > Julien Grall writes ("Re: [Xen-devel] [PATCH for-4.10] libxl: annotate s to > > be nonnull in libxl__enum_from_string"): > > > Release-acked-by: Julien Grall

Re: [Xen-devel] [PATCH for-4.10] libxl: annotate s to be nonnull in libxl__enum_from_string

2017-10-23 Thread Julien Grall
Hi, On 20/10/17 11:47, Ian Jackson wrote: Julien Grall writes ("Re: [Xen-devel] [PATCH for-4.10] libxl: annotate s to be nonnull in libxl__enum_from_string"): Release-acked-by: Julien Grall Thanks, I have applied this. Not sure whether this followup is 4.10

Re: [Xen-devel] [PATCH for-4.10] libxl: annotate s to be nonnull in libxl__enum_from_string

2017-10-20 Thread Ian Jackson
Julien Grall writes ("Re: [Xen-devel] [PATCH for-4.10] libxl: annotate s to be nonnull in libxl__enum_from_string"): > Release-acked-by: Julien Grall Thanks, I have applied this. Not sure whether this followup is 4.10 material, but IMO it is if we would otherwise want

Re: [Xen-devel] [PATCH for-4.10] libxl: annotate s to be nonnull in libxl__enum_from_string

2017-10-20 Thread Julien Grall
Hi, On 16/10/17 15:04, Wei Liu wrote: Hope this can placate coverity. Signed-off-by: Wei Liu --- Cc: Ian Jackson Cc: Julien Grall Release-acked-by: Julien Grall Cheers, ---

Re: [Xen-devel] [PATCH for-4.10] libxl: annotate s to be nonnull in libxl__enum_from_string

2017-10-16 Thread Ian Jackson
Andrew Cooper writes ("Re: [Xen-devel] [PATCH for-4.10] libxl: annotate s to be nonnull in libxl__enum_from_string"): > On 16/10/17 15:56, Ian Jackson wrote: > > We are very soon going to want "NN2" and maybe "NN_1_2". > > The hypervisor uses > > #define __nonnull(...)

Re: [Xen-devel] [PATCH for-4.10] libxl: annotate s to be nonnull in libxl__enum_from_string

2017-10-16 Thread Andrew Cooper
On 16/10/17 15:56, Ian Jackson wrote: > Wei Liu writes ("[PATCH for-4.10] libxl: annotate s to be nonnull in > libxl__enum_from_string"): >> Hope this can placate coverity. > Acked-by: Ian Jackson > > We are very soon going to want "NN2" and maybe "NN_1_2". The

Re: [Xen-devel] [PATCH for-4.10] libxl: annotate s to be nonnull in libxl__enum_from_string

2017-10-16 Thread Ian Jackson
Wei Liu writes ("[PATCH for-4.10] libxl: annotate s to be nonnull in libxl__enum_from_string"): > Hope this can placate coverity. Acked-by: Ian Jackson We are very soon going to want "NN2" and maybe "NN_1_2". Ian. ___

[Xen-devel] [PATCH for-4.10] libxl: annotate s to be nonnull in libxl__enum_from_string

2017-10-16 Thread Wei Liu
Hope this can placate coverity. Signed-off-by: Wei Liu --- Cc: Ian Jackson Cc: Julien Grall --- tools/libxl/libxl_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl_internal.h