Re: [Xen-devel] [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values

2015-07-21 Thread Ian Jackson
Roger Pau Monne writes ([PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values): We cannot use the systems errno values when checking return values from Xen, because some OSes don't have the same set of errno definitions. Instead use the definitions present in

Re: [Xen-devel] [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 07:14 -0600, Jan Beulich wrote: On 21.07.15 at 14:47, ian.campb...@citrix.com wrote: On Tue, 2015-07-21 at 13:40 +0100, Ian Jackson wrote: Andrew Cooper writes (Re: [Xen-devel] [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall

Re: [Xen-devel] [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values

2015-07-21 Thread Ian Jackson
Andrew Cooper writes (Re: [Xen-devel] [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values): EBADSLT isn't the only example here. I believe ENODATA is a similar example. http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/errno.h.html http

Re: [Xen-devel] [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values

2015-07-21 Thread Jan Beulich
On 21.07.15 at 14:47, ian.campb...@citrix.com wrote: On Tue, 2015-07-21 at 13:40 +0100, Ian Jackson wrote: Andrew Cooper writes (Re: [Xen-devel] [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values): EBADSLT isn't the only example here. I believe ENODATA

Re: [Xen-devel] [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 13:40 +0100, Ian Jackson wrote: Andrew Cooper writes (Re: [Xen-devel] [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values): EBADSLT isn't the only example here. I believe ENODATA is a similar example. http

[Xen-devel] [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values

2015-07-20 Thread Roger Pau Monne
We cannot use the systems errno values when checking return values from Xen, because some OSes don't have the same set of errno definitions. Instead use the definitions present in Xen public errno.h header. Signed-off-by: Roger Pau Monné roger@citrix.com Cc: Ian Jackson