Re: [Xen-devel] [PATCH for-4.8] x86/svm: Fix svm_nextrip_insn_length() when crossing the virtual boundary to 0

2016-11-21 Thread Boris Ostrovsky
On 11/21/2016 08:53 AM, Andrew Cooper wrote: > On 21/11/16 13:38, Boris Ostrovsky wrote: >> On 11/21/2016 05:40 AM, Andrew Cooper wrote: >>> On 16/11/16 10:51, Andrew Cooper wrote: vmcb->nextrip can legitimately be less than vmcb->rip when execution wraps back around to 0. Instead, compl

Re: [Xen-devel] [PATCH for-4.8] x86/svm: Fix svm_nextrip_insn_length() when crossing the virtual boundary to 0

2016-11-21 Thread Andrew Cooper
On 21/11/16 13:38, Boris Ostrovsky wrote: > On 11/21/2016 05:40 AM, Andrew Cooper wrote: >> On 16/11/16 10:51, Andrew Cooper wrote: >>> vmcb->nextrip can legitimately be less than vmcb->rip when execution wraps >>> back around to 0. Instead, complain if the reported length is greater than >>> 15

Re: [Xen-devel] [PATCH for-4.8] x86/svm: Fix svm_nextrip_insn_length() when crossing the virtual boundary to 0

2016-11-21 Thread Boris Ostrovsky
On 11/21/2016 05:40 AM, Andrew Cooper wrote: > On 16/11/16 10:51, Andrew Cooper wrote: >> vmcb->nextrip can legitimately be less than vmcb->rip when execution wraps >> back around to 0. Instead, complain if the reported length is greater than >> 15 >> and use x86_decode_insn() as a fallback. Why

Re: [Xen-devel] [PATCH for-4.8] x86/svm: Fix svm_nextrip_insn_length() when crossing the virtual boundary to 0

2016-11-21 Thread Andrew Cooper
On 16/11/16 10:51, Andrew Cooper wrote: > vmcb->nextrip can legitimately be less than vmcb->rip when execution wraps > back around to 0. Instead, complain if the reported length is greater than 15 > and use x86_decode_insn() as a fallback. > > While making changes here, fix two whitespace issues w

Re: [Xen-devel] [PATCH for-4.8] x86/svm: Fix svm_nextrip_insn_length() when crossing the virtual boundary to 0

2016-11-16 Thread Wei Liu
On Wed, Nov 16, 2016 at 03:56:04AM -0700, Jan Beulich wrote: > >>> On 16.11.16 at 11:51, wrote: > > vmcb->nextrip can legitimately be less than vmcb->rip when execution wraps > > back around to 0. Instead, complain if the reported length is greater than > > 15 > > and use x86_decode_insn() as a

Re: [Xen-devel] [PATCH for-4.8] x86/svm: Fix svm_nextrip_insn_length() when crossing the virtual boundary to 0

2016-11-16 Thread Jan Beulich
>>> On 16.11.16 at 11:51, wrote: > vmcb->nextrip can legitimately be less than vmcb->rip when execution wraps > back around to 0. Instead, complain if the reported length is greater than 15 > and use x86_decode_insn() as a fallback. > > While making changes here, fix two whitespace issues with t

[Xen-devel] [PATCH for-4.8] x86/svm: Fix svm_nextrip_insn_length() when crossing the virtual boundary to 0

2016-11-16 Thread Andrew Cooper
vmcb->nextrip can legitimately be less than vmcb->rip when execution wraps back around to 0. Instead, complain if the reported length is greater than 15 and use x86_decode_insn() as a fallback. While making changes here, fix two whitespace issues with the case labels. Signed-off-by: Andrew Coope