Re: [Xen-devel] [PATCH for-next v2 07/10] x86/domain: factor out pv_domain_destroy

2017-04-26 Thread Wei Liu
On Wed, Apr 26, 2017 at 07:29:34AM -0600, Jan Beulich wrote: > >>> On 26.04.17 at 14:56, wrote: > > On Wed, Apr 26, 2017 at 06:32:46AM -0600, Jan Beulich wrote: > >> >>> On 25.04.17 at 15:52, wrote: > >> > --- a/xen/arch/x86/domain.c > >> > +++

Re: [Xen-devel] [PATCH for-next v2 07/10] x86/domain: factor out pv_domain_destroy

2017-04-26 Thread Jan Beulich
>>> On 26.04.17 at 14:56, wrote: > On Wed, Apr 26, 2017 at 06:32:46AM -0600, Jan Beulich wrote: >> >>> On 25.04.17 at 15:52, wrote: >> > --- a/xen/arch/x86/domain.c >> > +++ b/xen/arch/x86/domain.c >> > @@ -536,6 +536,16 @@ static bool

Re: [Xen-devel] [PATCH for-next v2 07/10] x86/domain: factor out pv_domain_destroy

2017-04-26 Thread Wei Liu
On Wed, Apr 26, 2017 at 06:32:46AM -0600, Jan Beulich wrote: > >>> On 25.04.17 at 15:52, wrote: > > --- a/xen/arch/x86/domain.c > > +++ b/xen/arch/x86/domain.c > > @@ -536,6 +536,16 @@ static bool emulation_flags_ok(const struct domain *d, > > uint32_t emflags) > >

Re: [Xen-devel] [PATCH for-next v2 07/10] x86/domain: factor out pv_domain_destroy

2017-04-26 Thread Jan Beulich
>>> On 25.04.17 at 15:52, wrote: > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -536,6 +536,16 @@ static bool emulation_flags_ok(const struct domain *d, > uint32_t emflags) > return true; > } > > +static void pv_domain_destroy(struct domain *d) > +{

Re: [Xen-devel] [PATCH for-next v2 07/10] x86/domain: factor out pv_domain_destroy

2017-04-25 Thread Andrew Cooper
On 25/04/17 14:52, Wei Liu wrote: > No functional change. > > Signed-off-by: Wei Liu > --- > v2: > 1. reset fields > 2. destroy perdomain mapping You are introducing an additional destroy_perdomain_mapping(), and freeing of the cpuidmasks into this path. Functionally it is

[Xen-devel] [PATCH for-next v2 07/10] x86/domain: factor out pv_domain_destroy

2017-04-25 Thread Wei Liu
No functional change. Signed-off-by: Wei Liu --- v2: 1. reset fields 2. destroy perdomain mapping Cc: Jan Beulich Cc: Andrew Cooper --- xen/arch/x86/domain.c | 21 + 1 file changed, 13 insertions(+), 8