Re: [Xen-devel] [PATCH v10 2/3] x86emul: New return code for unimplemented instruction

2017-09-12 Thread Jan Beulich
>>> On 11.09.17 at 17:52, wrote: > On Jo, 2017-09-07 at 09:08 -0600, Jan Beulich wrote: >> > >> > > >> > > > >> > > > On 07.09.17 at 16:26, wrote: >> > After discussing with Andrew I'm willing to agree with the changes >> > you do here, with one extra requirement: At least on non-debug >> > bu

Re: [Xen-devel] [PATCH v10 2/3] x86emul: New return code for unimplemented instruction

2017-09-11 Thread Petre Ovidiu PIRCALABU
On Jo, 2017-09-07 at 09:08 -0600, Jan Beulich wrote: > > > > > > > > > > > > > On 07.09.17 at 16:26, wrote: > > After discussing with Andrew I'm willing to agree with the changes > > you do here, with one extra requirement: At least on non-debug > > builds X86EMUL_UNIMPLEMENTED should always re

Re: [Xen-devel] [PATCH v10 2/3] x86emul: New return code for unimplemented instruction

2017-09-07 Thread Jan Beulich
>>> On 07.09.17 at 16:26, wrote: > After discussing with Andrew I'm willing to agree with the changes > you do here, with one extra requirement: At least on non-debug > builds X86EMUL_UNIMPLEMENTED should always result in #UD being > raised by the final consumer of it. It should never, like would

Re: [Xen-devel] [PATCH v10 2/3] x86emul: New return code for unimplemented instruction

2017-09-07 Thread Andrew Cooper
On 06/09/17 14:48, Petre Pircalabu wrote: > diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c > index 64454c7..8a6eb74 100644 > --- a/xen/arch/x86/hvm/emulate.c > +++ b/xen/arch/x86/hvm/emulate.c > @@ -2044,6 +2044,7 @@ int hvm_emulate_one_mmio(unsigned long mfn, unsigned > long

Re: [Xen-devel] [PATCH v10 2/3] x86emul: New return code for unimplemented instruction

2017-09-07 Thread Jan Beulich
>>> On 06.09.17 at 15:48, wrote: > Enforce the distinction between an instruction not implemented by the > emulator and the failure to emulate that instruction by defining a new > return code, X86EMUL_UNIMPLEMENTED. > > This value should only be returned by the core emulator only if it fails to >

[Xen-devel] [PATCH v10 2/3] x86emul: New return code for unimplemented instruction

2017-09-06 Thread Petre Pircalabu
Enforce the distinction between an instruction not implemented by the emulator and the failure to emulate that instruction by defining a new return code, X86EMUL_UNIMPLEMENTED. This value should only be returned by the core emulator only if it fails to properly decode the current instruction's opc