Re: [Xen-devel] [PATCH v12 05/10] x86: add multiboot2 protocol support for EFI platforms

2017-01-20 Thread Daniel Kiper
On Fri, Jan 20, 2017 at 02:34:35PM -0500, Doug Goldstein wrote: > On 1/19/17 8:34 PM, Daniel Kiper wrote: > > diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h > > index 62c010e..c1285ad 100644 > > --- a/xen/arch/x86/efi/efi-boot.h > > +++ b/xen/arch/x86/efi/efi-boot.h > > > +

Re: [Xen-devel] [PATCH v12 05/10] x86: add multiboot2 protocol support for EFI platforms

2017-01-20 Thread Doug Goldstein
On 1/19/17 8:34 PM, Daniel Kiper wrote: > diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h > index 62c010e..c1285ad 100644 > --- a/xen/arch/x86/efi/efi-boot.h > +++ b/xen/arch/x86/efi/efi-boot.h > + > +efi_exit_boot(ImageHandle, SystemTable); > + > +/* Return

Re: [Xen-devel] [PATCH v12 05/10] x86: add multiboot2 protocol support for EFI platforms

2017-01-20 Thread Andrew Cooper
On 20/01/17 19:04, Doug Goldstein wrote: > On 1/19/17 8:34 PM, Daniel Kiper wrote: >> This way Xen can be loaded on EFI platforms using GRUB2 and >> other boot loaders which support multiboot2 protocol. >> >> Signed-off-by: Daniel Kiper >> --- >> v12 - suggestions/fixes:

Re: [Xen-devel] [PATCH v12 05/10] x86: add multiboot2 protocol support for EFI platforms

2017-01-20 Thread Doug Goldstein
On 1/19/17 8:34 PM, Daniel Kiper wrote: > This way Xen can be loaded on EFI platforms using GRUB2 and > other boot loaders which support multiboot2 protocol. > > Signed-off-by: Daniel Kiper > --- > v12 - suggestions/fixes: > - rename __efi64_start to

Re: [Xen-devel] [PATCH v12 05/10] x86: add multiboot2 protocol support for EFI platforms

2017-01-20 Thread Jan Beulich
>>> On 20.01.17 at 15:43, wrote: > On Fri, Jan 20, 2017 at 07:10:32AM -0700, Jan Beulich wrote: >> >>> On 20.01.17 at 14:46, wrote: >> > On Fri, Jan 20, 2017 at 05:40:55AM -0700, Jan Beulich wrote: >> >> >>> On 20.01.17 at 12:43,

Re: [Xen-devel] [PATCH v12 05/10] x86: add multiboot2 protocol support for EFI platforms

2017-01-20 Thread Daniel Kiper
On Fri, Jan 20, 2017 at 07:10:32AM -0700, Jan Beulich wrote: > >>> On 20.01.17 at 14:46, wrote: > > On Fri, Jan 20, 2017 at 05:40:55AM -0700, Jan Beulich wrote: > >> >>> On 20.01.17 at 12:43, wrote: > >> > On Fri, Jan 20, 2017 at 02:46:47AM

Re: [Xen-devel] [PATCH v12 05/10] x86: add multiboot2 protocol support for EFI platforms

2017-01-20 Thread Jan Beulich
>>> On 20.01.17 at 14:46, wrote: > On Fri, Jan 20, 2017 at 05:40:55AM -0700, Jan Beulich wrote: >> >>> On 20.01.17 at 12:43, wrote: >> > On Fri, Jan 20, 2017 at 02:46:47AM -0700, Jan Beulich wrote: >> >> >>> On 20.01.17 at 02:34,

Re: [Xen-devel] [PATCH v12 05/10] x86: add multiboot2 protocol support for EFI platforms

2017-01-20 Thread Daniel Kiper
On Fri, Jan 20, 2017 at 05:40:55AM -0700, Jan Beulich wrote: > >>> On 20.01.17 at 12:43, wrote: > > On Fri, Jan 20, 2017 at 02:46:47AM -0700, Jan Beulich wrote: > >> >>> On 20.01.17 at 02:34, wrote: [...] > >> > +.Lefi_multiboot2_proto: > >> >

Re: [Xen-devel] [PATCH v12 05/10] x86: add multiboot2 protocol support for EFI platforms

2017-01-20 Thread Jan Beulich
>>> On 20.01.17 at 12:43, wrote: > On Fri, Jan 20, 2017 at 02:46:47AM -0700, Jan Beulich wrote: >> >>> On 20.01.17 at 02:34, wrote: >> > @@ -100,20 +107,48 @@ multiboot2_header_start: >> > gdt_boot_descr: >> > .word 6*8-1 >> >

Re: [Xen-devel] [PATCH v12 05/10] x86: add multiboot2 protocol support for EFI platforms

2017-01-20 Thread Daniel Kiper
On Fri, Jan 20, 2017 at 02:46:47AM -0700, Jan Beulich wrote: > >>> On 20.01.17 at 02:34, wrote: > > @@ -100,20 +107,48 @@ multiboot2_header_start: > > gdt_boot_descr: > > .word 6*8-1 > > .long sym_phys(trampoline_gdt) > > +.long 0 /*

Re: [Xen-devel] [PATCH v12 05/10] x86: add multiboot2 protocol support for EFI platforms

2017-01-20 Thread Jan Beulich
>>> On 20.01.17 at 02:34, wrote: > @@ -100,20 +107,48 @@ multiboot2_header_start: > gdt_boot_descr: > .word 6*8-1 > .long sym_phys(trampoline_gdt) > +.long 0 /* Needed for 64-bit lgdt */ > + > +.align 4 > +vga_text_buffer: > +

Re: [Xen-devel] [PATCH v12 05/10] x86: add multiboot2 protocol support for EFI platforms

2017-01-19 Thread Doug Goldstein
On 1/19/17 8:34 PM, Daniel Kiper wrote: > diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S > index 84cf44d..b8f727a 100644 > --- a/xen/arch/x86/boot/head.S > +++ b/xen/arch/x86/boot/head.S > -2: /* Reserve 64kb for the trampoline */ > -sub $0x1000,%ecx > +

[Xen-devel] [PATCH v12 05/10] x86: add multiboot2 protocol support for EFI platforms

2017-01-19 Thread Daniel Kiper
This way Xen can be loaded on EFI platforms using GRUB2 and other boot loaders which support multiboot2 protocol. Signed-off-by: Daniel Kiper --- v12 - suggestions/fixes: - rename __efi64_start to __efi64_mb2_start (suggested by Andrew Cooper), - use