[Xen-devel] [PATCH v2] blktap2: update connection handling to fix build with gcc5

2015-07-21 Thread Olaf Hering
blktap2 fails to build with gcc5 because it fails to recognize that there can be just one active connection (enforced in ctl_accept). Add a hack to use MAX_CONNECTIONS instead of ARRAY_SIZE: gives a smaller patch, and the code does not handle holes in connections[] anyway. [ 198s] block-log.c:

Re: [Xen-devel] [PATCH v2] blktap2: update connection handling to fix build with gcc5

2015-07-21 Thread Jan Beulich
On 21.07.15 at 10:42, o...@aepfle.de wrote: --- a/tools/blktap2/drivers/block-log.c +++ b/tools/blktap2/drivers/block-log.c @@ -359,7 +359,7 @@ static int ctl_close_sock(struct tdlog_state* s, int fd) { int i; - for (i = 0; i s-connected; i++) { + for (i = 0; i s-connected i

Re: [Xen-devel] [PATCH v2] blktap2: update connection handling to fix build with gcc5

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 02:48 -0600, Jan Beulich wrote: On 21.07.15 at 10:42, o...@aepfle.de wrote: --- a/tools/blktap2/drivers/block-log.c +++ b/tools/blktap2/drivers/block-log.c @@ -359,7 +359,7 @@ static int ctl_close_sock(struct tdlog_state* s, int fd) { int i; - for (i =