Re: [Xen-devel] [PATCH v2] libelf: drop pointless uses of __FUNCTION__

2016-09-07 Thread Ian Jackson
Jan Beulich writes ("[PATCH v2] libelf: drop pointless uses of __FUNCTION__"): > Non-debugging message text should be (and is in the cases here, albeit > often only with the addition of an ELF: prefix) distinguishable without > also logging function names. > > In the messages touched at once use

Re: [Xen-devel] [PATCH v2] libelf: drop pointless uses of __FUNCTION__

2016-09-07 Thread Jan Beulich
>>> On 07.09.16 at 09:59, wrote: > Non-debugging message text should be (and is in the cases here, albeit > often only with the addition of an ELF: prefix) distinguishable without > also logging function names. > > In the messages touched at once use %#x (or variants thereof)

[Xen-devel] [PATCH v2] libelf: drop pointless uses of __FUNCTION__

2016-09-07 Thread Jan Beulich
Non-debugging message text should be (and is in the cases here, albeit often only with the addition of an ELF: prefix) distinguishable without also logging function names. In the messages touched at once use %#x (or variants thereof) in favor of 0x%x. --- v2: Add a missing ELF: prefix. Further