Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device

2015-09-01 Thread Ian Campbell
On Tue, 2015-09-01 at 12:28 +0100, Ian Jackson wrote: > David Vrabel writes ("Re: [Xen-devel] [PATCH v2] libxenstore: prefer > using the character device"): > > On 27/08/15 19:03, Ian Jackson wrote: > > > I confess I still see this as working around a kernel bu

Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device

2015-09-01 Thread Ian Jackson
David Vrabel writes ("Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device"): > On 27/08/15 19:03, Ian Jackson wrote: > > I confess I still see this as working around a kernel bug. Only this > > time we are switching from a buggy to non-buggy kernel

Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device

2015-09-01 Thread Wei Liu
On Mon, Aug 31, 2015 at 01:59:24PM -0500, Jonathan Creekmore wrote: > Just wanted to follow-up and see if there was any more debate on this, since > I hadn't seen any other commentary since last week. > After reading all replies to this thread I'm of the opinion that this patch should be applied.

Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device

2015-08-31 Thread Jonathan Creekmore
Just wanted to follow-up and see if there was any more debate on this, since I hadn't seen any other commentary since last week. David Vrabel writes: On 27/08/15 19:03, Ian Jackson wrote: Wei Liu writes ("Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device&

Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device

2015-08-28 Thread David Vrabel
On 27/08/15 19:03, Ian Jackson wrote: > Wei Liu writes ("Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the > character device"): >> On Thu, Aug 27, 2015 at 09:04:38AM -0500, Jonathan Creekmore wrote: >>> With the addition of FMODE_ATOMIC_POS in the Li

Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device

2015-08-27 Thread Jonathan Creekmore
Ian Jackson writes: Wei Liu writes ("Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device"): On Thu, Aug 27, 2015 at 09:04:38AM -0500, Jonathan Creekmore wrote: > With the addition of FMODE_ATOMIC_POS in the Linux 3.14 > kernel, concurrent blocking fi

Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device

2015-08-27 Thread Ian Jackson
Wei Liu writes ("Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device"): > On Thu, Aug 27, 2015 at 09:04:38AM -0500, Jonathan Creekmore wrote: > > With the addition of FMODE_ATOMIC_POS in the Linux 3.14 kernel, > > concurrent blocking file acces

Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device

2015-08-27 Thread Wei Liu
On Thu, Aug 27, 2015 at 09:04:38AM -0500, Jonathan Creekmore wrote: > With the addition of FMODE_ATOMIC_POS in the Linux 3.14 kernel, > concurrent blocking file accesses to a single open file descriptor can > cause a deadlock trying to grab the file position lock. If a watch has > been set up, caus

[Xen-devel] [PATCH v2] libxenstore: prefer using the character device

2015-08-27 Thread Jonathan Creekmore
With the addition of FMODE_ATOMIC_POS in the Linux 3.14 kernel, concurrent blocking file accesses to a single open file descriptor can cause a deadlock trying to grab the file position lock. If a watch has been set up, causing a read_thread to blocking read on the file descriptor, then future write