Re: [Xen-devel] [PATCH v2] libxl: fix handling of returns in libxl_get_version_info()

2016-02-12 Thread Harmandeep Kaur
On Fri, Feb 12, 2016 at 6:39 PM, Dario Faggioli wrote: > On Fri, 2016-02-12 at 12:31 +, Wei Liu wrote: >> On Fri, Feb 12, 2016 at 05:00:40PM +0530, Harmandeep Kaur wrote: >> > >> > +info->xen_version_major = r >> 16; >> > +info->xen_version_minor = r & 0xFF; >> > >> > -xc_version(c

Re: [Xen-devel] [PATCH v2] libxl: fix handling of returns in libxl_get_version_info()

2016-02-12 Thread Dario Faggioli
On Fri, 2016-02-12 at 12:31 +, Wei Liu wrote: > On Fri, Feb 12, 2016 at 05:00:40PM +0530, Harmandeep Kaur wrote: > >  > > +info->xen_version_major = r >> 16; > > +info->xen_version_minor = r & 0xFF; > >   > > -xc_version(ctx->xch, XENVER_extraversion, &u.xen_extra); > > +r = xc_

Re: [Xen-devel] [PATCH v2] libxl: fix handling of returns in libxl_get_version_info()

2016-02-12 Thread Wei Liu
On Fri, Feb 12, 2016 at 05:00:40PM +0530, Harmandeep Kaur wrote: > Check the return value of xc_version() and return NULL if it > fails. libxl_get_version_info() can also return NULL now. > Callers of the function libxl_get_version_info() are already > prepared to deal with returning NULL on failur

[Xen-devel] [PATCH v2] libxl: fix handling of returns in libxl_get_version_info()

2016-02-12 Thread Harmandeep Kaur
Check the return value of xc_version() and return NULL if it fails. libxl_get_version_info() can also return NULL now. Callers of the function libxl_get_version_info() are already prepared to deal with returning NULL on failure of xc_version(). Coverity ID 1351217 Signed-off-by: Harmandeep Kaur