Re: [Xen-devel] [PATCH v2] vsprintf: Make sure argument to %pX specifier is valid

2015-02-12 Thread Andrew Cooper
On 11/02/15 20:58, Boris Ostrovsky wrote: If invalid pointer (i.e. something smaller than HYPERVISOR_VIRT_START) is passed for %*ph/%pv/%ps/%pS format specifiers then print (NULL) Signed-off-by: Boris Ostrovsky boris.ostrov...@oracle.com --- xen/common/vsprintf.c | 23

Re: [Xen-devel] [PATCH v2] vsprintf: Make sure argument to %pX specifier is valid

2015-02-12 Thread Boris Ostrovsky
On 02/12/2015 06:04 AM, Andrew Cooper wrote: On 11/02/15 20:58, Boris Ostrovsky wrote: If invalid pointer (i.e. something smaller than HYPERVISOR_VIRT_START) is passed for %*ph/%pv/%ps/%pS format specifiers then print (NULL) Signed-off-by: Boris Ostrovsky boris.ostrov...@oracle.com ---

Re: [Xen-devel] [PATCH v2] vsprintf: Make sure argument to %pX specifier is valid

2015-02-12 Thread Andrew Cooper
On 12/02/15 15:01, Boris Ostrovsky wrote: On 02/12/2015 06:04 AM, Andrew Cooper wrote: On 11/02/15 20:58, Boris Ostrovsky wrote: If invalid pointer (i.e. something smaller than HYPERVISOR_VIRT_START) is passed for %*ph/%pv/%ps/%pS format specifiers then print (NULL) Signed-off-by: Boris

Re: [Xen-devel] [PATCH v2] vsprintf: Make sure argument to %pX specifier is valid

2015-02-12 Thread Boris Ostrovsky
On 02/12/2015 10:21 AM, Andrew Cooper wrote: On 12/02/15 15:01, Boris Ostrovsky wrote: On 02/12/2015 06:04 AM, Andrew Cooper wrote: On 11/02/15 20:58, Boris Ostrovsky wrote: If invalid pointer (i.e. something smaller than HYPERVISOR_VIRT_START) is passed for %*ph/%pv/%ps/%pS format specifiers

Re: [Xen-devel] [PATCH v2] vsprintf: Make sure argument to %pX specifier is valid

2015-02-12 Thread Andrew Cooper
On 12/02/15 15:38, Boris Ostrovsky wrote: On 02/12/2015 10:21 AM, Andrew Cooper wrote: On 12/02/15 15:01, Boris Ostrovsky wrote: On 02/12/2015 06:04 AM, Andrew Cooper wrote: On 11/02/15 20:58, Boris Ostrovsky wrote: If invalid pointer (i.e. something smaller than HYPERVISOR_VIRT_START) is

Re: [Xen-devel] [PATCH v2] vsprintf: Make sure argument to %pX specifier is valid

2015-02-12 Thread Boris Ostrovsky
On 02/12/2015 11:33 AM, Boris Ostrovsky wrote: Also, for %*ph format, if we just go with falling through to plain format and not marking somehow that we are printing a bad pointer: unsigned badval = 0xab; unsigned *badptr = badval; printk(badptr = %*ph\n, 1, badptr); console:

Re: [Xen-devel] [PATCH v2] vsprintf: Make sure argument to %pX specifier is valid

2015-02-12 Thread Andrew Cooper
On 12/02/15 16:33, Boris Ostrovsky wrote: On 02/12/2015 10:48 AM, Andrew Cooper wrote: On 12/02/15 15:38, Boris Ostrovsky wrote: On 02/12/2015 10:21 AM, Andrew Cooper wrote: On 12/02/15 15:01, Boris Ostrovsky wrote: On 02/12/2015 06:04 AM, Andrew Cooper wrote: On 11/02/15 20:58, Boris

[Xen-devel] [PATCH v2] vsprintf: Make sure argument to %pX specifier is valid

2015-02-11 Thread Boris Ostrovsky
If invalid pointer (i.e. something smaller than HYPERVISOR_VIRT_START) is passed for %*ph/%pv/%ps/%pS format specifiers then print (NULL) Signed-off-by: Boris Ostrovsky boris.ostrov...@oracle.com --- xen/common/vsprintf.c | 23 --- 1 files changed, 16 insertions(+), 7